You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/08 16:57:46 UTC

[GitHub] GJL opened a new pull request #7671: [FLINK-11549][tests] Remove obsolete ResourceManagerITCase

GJL opened a new pull request #7671: [FLINK-11549][tests] Remove obsolete ResourceManagerITCase
URL: https://github.com/apache/flink/pull/7671
 
 
   ## What is the purpose of the change
   
   *This removes the test `ResourceManagerITCase`. The test verified that:*
   
     - *RM gets informed upon TM registration*
     - *RM reconciles existing TMs*
   
   *I think the test can be removed because there is sufficient coverage for the new code base:*
   
     - *`ResourceManagerTest#testRequestTaskManagerInfo` – Tests that TM can register with RM*
     - *`TaskExecutorTest#testMaximumRegistrationDurationAfterConnectionLoss` – Tests that TM retries registration with RM*
   
   ## Brief change log
   
     - *Delete `ResourceManagerITCase`*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services