[GitHub] [druid] kfaraz commented on issue #13025: Prometheus-emitter does not push metrics to the pushgateway server

[GitBox <gi...@apache.org>]

kfaraz commented on issue #13025:
URL: https://github.com/apache/druid/issues/13025#issuecomment-1240255903

   > There're many emitters that have a scheduler, such as KafkaEmitter, and GraphiteEmitter.
   I'm wondering if we can abstract such scheduler mechanism to Emitter interface so that any implementations won't do it by itself and they won't forget to do it. This might be out of the scope of the fix of current problem.
   
   Yes, @FrankChen021,  we should extracted out this common requirement. `HttpPostEmitter` uses a separate `EmittingThread` too, and seems to have an involved batching logic. I suppose all of this should be consolidated in a common emitter utility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org