[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1298: [CELEBORN-359][FOLLOWUP] Update LICENSE and NOTICE for ratis-shell

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1298:
URL: https://github.com/apache/incubator-celeborn/pull/1298#discussion_r1122707330


##########
LICENSE-binary:
##########
@@ -257,12 +258,16 @@ org.apache.ratis:ratis-netty
 org.apache.ratis:ratis-proto
 org.apache.ratis:ratis-server
 org.apache.ratis:ratis-server-api
+org.apache.ratis:ratis-shell
 org.apache.ratis:ratis-thirdparty-misc
+org.javassist:javassist
+org.reflections:reflections
 org.roaringbitmap:RoaringBitmap
 org.roaringbitmap:shims
 org.scala-lang:scala-library
 org.scala-lang:scala-reflect
 org.slf4j:jcl-over-slf4j
+org.slf4j:slf4j-simple

Review Comment:
   > we should exclude it since we use log4j2
   
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org