You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/12 16:32:53 UTC
[GitHub] [camel-k] essobedo opened a new pull request, #3544: fix(trait): force a volume path when key is set
essobedo opened a new pull request, #3544:
URL: https://github.com/apache/camel-k/pull/3544
## Motivation
When we try to run an integration that needs to mount a volume with filtering but without a path, it fails with `[spec.template.spec.volumes[2].secret.items[0].path: Required``
## Modifications:
* Use the key when no mount path is proposed
**Release Note**
```release-note
fix(trait): force a volume path when key is set
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3544: fix(trait): force a volume path when key is set
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3544:
URL: https://github.com/apache/camel-k/pull/3544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] essobedo commented on pull request #3544: fix(trait): force a volume path when key is set
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3544:
URL: https://github.com/apache/camel-k/pull/3544#issuecomment-1222075693
> LGTM. Only one request is to cover the case with an E2E test. Could you please add test runs with key filtering scenarios after the following ones for both configmap and secret? https://github.com/apache/camel-k/blob/main/e2e/global/common/config/config_test.go#L84 https://github.com/apache/camel-k/blob/main/e2e/global/common/config/config_test.go#L143
Yes, of course, thx for the feedback, however, please note that I won't be able to do that before next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org