You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Erik Bergenholtz <eb...@hortonworks.com> on 2015/05/22 20:29:39 UTC

Review Request 34604: Stability Changes for Hive View

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34604/
-----------------------------------------------------------

Review request for Ambari, aantonioxrr aantonioxrr and Tom Beerbower.


Repository: ambari


Description
-------

Column search should be case-sensitive for hive view
Changed version to 0.4
Added support for user level settings
Progress bar query Support
Caching of Visual Explain results/rendering
Ability to name hive results file prior to download
Ability to rename tabs by double-clicking


Diffs
-----

  contrib/views/hive/pom.xml f3f8f36 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 15ebd09 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java bae46ac 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java 061c449 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMRequestsDelegateImpl.java 6050fec 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/Job.java dc4dfa8 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java dc3f624 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java 82e0896 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/HdfsApi.java 844bc80 
  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/HdfsUtil.java 7386ee4 
  contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/application.js cf2511d 
  contrib/views/hive/src/main/resources/ui/hive-web/app/components/column-filter-widget.js cbf0ddd 
  contrib/views/hive/src/main/resources/ui/hive-web/app/components/extended-input.js ee2161c 
  contrib/views/hive/src/main/resources/ui/hive-web/app/components/tabs-widget.js 2a898f5 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 77b5fe5 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js fa79048 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/results.js dc7c199 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js 8add9a1 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/settings.js 0bb540f 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/tez-ui.js bdb66a1 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js dfd9889 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js e5bb82b 
  contrib/views/hive/src/main/resources/ui/hive-web/app/models/job.js 472f824 
  contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 90b8055 
  contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 7f73f8f 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 488fe04 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/mixins.scss 3e85727 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/query-tabs.scss 3bc3095 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/panel-widget.hbs 1e29033 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/tabs-widget.hbs 5f9c18c 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs 47becfd 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index/history-query/results.hbs 06c21e4 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/open-queries.hbs fdf5597 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings-global.hbs PRE-CREATION 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings-query.hbs PRE-CREATION 
  contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings.hbs 98f0b54 
  contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 595da4a 
  contrib/views/hive/src/main/resources/ui/hive-web/app/utils/functions.js a1901c7 
  contrib/views/hive/src/main/resources/ui/hive-web/app/views/messages.js 73a7b76 
  contrib/views/hive/src/main/resources/ui/hive-web/app/views/tez-ui.js c14fd34 
  contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js 8d90b7e 
  contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/index-test.js cc7d953 
  contrib/views/hive/src/main/resources/view.xml 64526d5 
  contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/AggregatorTest.java de691e0 

Diff: https://reviews.apache.org/r/34604/diff/


Testing
-------

Deployed to local cluster, unit tests:

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.491 sec
Running org.apache.ambari.view.hive.resources.files.FileServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.119 sec 
Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 sec
Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.173 sec
Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.118 sec
Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.681 sec
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.631 sec 
Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.644 sec


Thanks,

Erik Bergenholtz


Re: Review Request 34604: Stability Changes for Hive View

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34604/#review84963
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On May 22, 2015, 6:29 p.m., Erik Bergenholtz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34604/
> -----------------------------------------------------------
> 
> (Updated May 22, 2015, 6:29 p.m.)
> 
> 
> Review request for Ambari, aantonioxrr aantonioxrr and Tom Beerbower.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Column search should be case-sensitive for hive view
> Changed version to 0.4
> Added support for user level settings
> Progress bar query Support
> Caching of Visual Explain results/rendering
> Ability to name hive results file prior to download
> Ability to rename tabs by double-clicking
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/pom.xml f3f8f36 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/Connection.java 15ebd09 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/files/FileService.java bae46ac 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java 061c449 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/rm/RMRequestsDelegateImpl.java 6050fec 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/Job.java dc4dfa8 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java dc3f624 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java 82e0896 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/HdfsApi.java 844bc80 
>   contrib/views/hive/src/main/java/org/apache/ambari/view/hive/utils/HdfsUtil.java 7386ee4 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/application.js cf2511d 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/components/column-filter-widget.js cbf0ddd 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/components/extended-input.js ee2161c 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/components/tabs-widget.js 2a898f5 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 77b5fe5 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js fa79048 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/results.js dc7c199 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/open-queries.js 8add9a1 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/settings.js 0bb540f 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/tez-ui.js bdb66a1 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/visual-explain.js dfd9889 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js e5bb82b 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/models/job.js 472f824 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/application.js 90b8055 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 7f73f8f 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 488fe04 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/mixins.scss 3e85727 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/query-tabs.scss 3bc3095 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/panel-widget.hbs 1e29033 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/tabs-widget.hbs 5f9c18c 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index.hbs 47becfd 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index/history-query/results.hbs 06c21e4 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/open-queries.hbs fdf5597 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings-global.hbs PRE-CREATION 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings-query.hbs PRE-CREATION 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/settings.hbs 98f0b54 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 595da4a 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/functions.js a1901c7 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/views/messages.js 73a7b76 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/views/tez-ui.js c14fd34 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/views/visual-explain.js 8d90b7e 
>   contrib/views/hive/src/main/resources/ui/hive-web/tests/unit/controllers/index-test.js cc7d953 
>   contrib/views/hive/src/main/resources/view.xml 64526d5 
>   contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/AggregatorTest.java de691e0 
> 
> Diff: https://reviews.apache.org/r/34604/diff/
> 
> 
> Testing
> -------
> 
> Deployed to local cluster, unit tests:
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.apache.ambari.view.hive.backgroundjobs.BackgroundJobControllerTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.491 sec
> Running org.apache.ambari.view.hive.resources.files.FileServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.119 sec 
> Running org.apache.ambari.view.hive.resources.jobs.AggregatorTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.29 sec
> Running org.apache.ambari.view.hive.resources.jobs.ATSParserTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 sec
> Running org.apache.ambari.view.hive.resources.jobs.JobServiceTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.173 sec
> Running org.apache.ambari.view.hive.resources.jobs.LogParserTest
> Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.118 sec
> Running org.apache.ambari.view.hive.resources.resources.FileResourceServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.681 sec
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.631 sec 
> Running org.apache.ambari.view.hive.resources.udfs.UDFServiceTest
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.644 sec
> 
> 
> Thanks,
> 
> Erik Bergenholtz
> 
>