You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2009/06/10 13:02:07 UTC
[jira] Commented: (LUCENE-1679) Make WildcardTermEnum#difference()
non-final
[ https://issues.apache.org/jira/browse/LUCENE-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718029#action_12718029 ]
Michael McCandless commented on LUCENE-1679:
--------------------------------------------
I like the cleanup patch, but, I think we should not remove close()? Even though it's basically a no-op, removing it breaks back-compat.
Technically, changing the members to final is also a break to back-compat, but I think it's acceptable because WildcardTermEnum basically requires that these are final (ie, you can't up and change say "pre" after creation, because the enum has already been set).
> Make WildcardTermEnum#difference() non-final
> --------------------------------------------
>
> Key: LUCENE-1679
> URL: https://issues.apache.org/jira/browse/LUCENE-1679
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Affects Versions: 2.9
> Reporter: Simon Willnauer
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: WildcardTermEnum.patch, WildcardTermEnum_cleanup.patch
>
>
> The method WildcardTermEnum#difference() is declared final. I found it very useful to subclass WildcardTermEnum to implement different scoring for exact vs. partial matches. The change is rather trivial (attached) but I guess it could make life easier for a couple of users.
> I attached two patches:
> - one which contains the single change to make difference() non-final (WildcardTermEnum.patch)
> - one which does also contain some minor cleanup of WildcardTermEnum. I removed unnecessary member initialization and made those final. ( WildcardTermEnum_cleanup.patch)
> Thanks simon
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org