You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:26:51 UTC

[GitHub] [zookeeper] eolivelli opened a new pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

eolivelli opened a new pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg closed pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

Posted by GitBox <gi...@apache.org>.
ztzg closed pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573#issuecomment-756115757


   @ztzg please consider picking up this patch before cutting 3.7.0, it is trivial but it allows builds on JDK16


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573#issuecomment-758811917


   @eolivelli: Should I merge this (trivial) or do we need a second approval?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] eolivelli commented on pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573#issuecomment-759076790


   you can merge it :-)
   our rule is that we need 2 committers to sponsor the patch, in this case me and you is enough


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573#issuecomment-756302077


   > @ztzg please consider picking up this patch before cutting 3.7.0, it is trivial but it allows builds on JDK16
   
   Okay, noted!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1573: ZOOKEEPER-4048 Upgrade Mockito to 3.6.28 - allow builds on JDK16

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1573:
URL: https://github.com/apache/zookeeper/pull/1573#issuecomment-759287213


   > you can merge it :-)
   
   Okay, now in `master`.
   
   > our rule is that we need 2 committers to sponsor the patch, in this case me and you is enough
   
   Right.  I'm never sure—the patch is certainly trivial, but the ramifications may not be.  (I haven't had a "chance" to look into the innards of Mockito so far.  I'm sure they're gnarly :)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org