[GitHub] [arrow-datafusion] Jefffrey commented on a diff in pull request #5820: fix: Coerce case expression and when to common type

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on code in PR #5820:
URL: https://github.com/apache/arrow-datafusion/pull/5820#discussion_r1155095820


##########
datafusion/core/tests/sqllogictests/test_files/select.slt:
##########
@@ -214,3 +214,9 @@ select * from (select 1 a union all select 2) b order by a limit null;
 query I
 select * from (select 1 a union all select 2) b order by a limit 0;
 ----
+
+# select case when type coercion
+query I
+select CASE 10.5 WHEN 0 THEN 1 ELSE 10 END as col;
+----
+10

Review Comment:
   Is there a way in sqllogictests to change the config of DataFusion? Since for negative cases to produce error, would need to set `datafusion.optimizer.skip_failed_rules` to false, unless you mean for the negative case to fail as in the original issue?
   
   Otherwise can add the negative case as a unit test in actual code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org