You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2015/03/19 17:34:42 UTC
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-30 Kill callbacks.h
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/5
CLOWNFISH-30 Kill callbacks.h
Refactor CFC internals to eliminate an autogenerated file and centralize some code generation rather than perform generation per-host.
This fixes CLOWNFISH-30.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish CLOWNFISH-30-kill-callbacks-h
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit c3df5a6ac10a0a7872039cd800772eb30c1be022
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-03-17T18:03:28Z
Eliminate generation and usage of callbacks.h.
* Declare OVERRIDE symbols in per-class header files.
* Make signatures for invalid OVERRIDES match the original method.
* Generate OVERRIDE symbols centrally rather than for each host.
commit e45af211522b700ae922474c716a8f1f1166fea9
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-03-19T16:30:50Z
Eliminate vestigial function to write callbacks.h.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-30 Kill callbacks.h
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy-clownfish/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---