You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/08/23 16:11:00 UTC
[Issue 125495] New: Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Issue ID: 125495
Issue Type: DEFECT
Summary: Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Product: Writer
Version: 4.1.0
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: open-import
Assignee: issues@openoffice.apache.org
Reporter: marklh9@gmail.com
Created attachment 83880
--> https://issues.apache.org/ooo/attachment.cgi?id=83880&action=edit
Illustration for the issue
Create different types of traditional Chinese numbering list in MSO 2010 (
ZH-TW). Open the file with OpenOffice, Chinese numbering suffix become awkward
characters.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pescetti@apache.org
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marklh9@gmail.com
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #11 from Mark Hung <ma...@gmail.com> ---
Hi Steve,
No update. My patch uploaded on Aug. 23 is OK. Please merge the patch if the
solution is acceptable for you.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #8 from Mark Hung <ma...@gmail.com> ---
(In reply to Oliver-Rainer Wittmann from comment #7)
> First, I think we can change the issue status to confirmed as we are already
> reviewing the applied patch.
>
> Second, I will also have a look at the patch
>
> Third, some questions:
> - Does the patch also fixes the RTF export?
No. It's for import instead of export.
> - Does the patch also fixes the WW8 (*.doc) import/export as Steve mentioned?
No. It has nothing to do with WW8 as far as I know.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #5 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #4)
> Created attachment 83889 [details]
> Screenshot for the effect of the patch in Linux.
>
> The screenshot is taken under my environment, which is a Ubuntu 12 VM.
> Note that this screenshot also include the fix of Chinese numbering issue of
> 125400, which is independent of this issue.
>
> Uname -a list as follows:
> Linux ubuntu 3.11.0-15-generic #25~precise1-Ubuntu SMP Thu Jan 30 17:39:31
> UTC 2014 x86_64 x86_64 x86_64 GNU/Linux.
>
> I haven't setup environment for Windows yet, so I can't verified this patch
> in Windows.
>
> Have you applied the patch successfully? I just found that I made diff under
> svtools module instead of main or top directory.
> Which environment are you testing?
Confirmed. I was misled by the first screenshot. I tested the sample on Win 7
Pro 64bit and Mac OS 10.7.5.
The patch works for rtf/doc import/export except docx import.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #9 from Mark Hung <ma...@gmail.com> ---
Hi Developers,
What's happening?
Is there anyone working on verifying or merging the patch?
Do I need to improve anything or provide any information
in order to get it merged?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Steve Yin <st...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #11)
> Hi Steve,
>
> No update. My patch uploaded on Aug. 23 is OK. Please merge the patch if the
> solution is acceptable for you.
It's OK. The patch was delivered.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #1 from Mark Hung <ma...@gmail.com> ---
Created attachment 83881
--> https://issues.apache.org/ooo/attachment.cgi?id=83881&action=edit
Patch to fix Chinese numbering suffix issue in RTF parser
Because codepage encoding options like \ansicp950 appears later than the first
bracket '{', the first parsing state has been pushed into the stack before
correct encoding were set. Later when it was popped, the encoding of later
state were affected and become the default even if \ansicp950 already appears,
in consequence it affect multibyte string conversion for text token. Updated
code will overwrite the encoding of the state on top of the frame, and has
verified to work in my environment.
In theory , all multibyte chracter encoding ( not merely ZH-TTW) were affected.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Steve Yin <st...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |steve.yin.aoo@gmail.com
--- Comment #3 from Steve Yin <st...@gmail.com> ---
(In reply to Mark Hung from comment #2)
> Created attachment 83882 [details]
> Sample test case.
This patch does not work with the sample. Can you check it?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Mark Hung <ma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Issue Type|DEFECT |PATCH
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #13 from SVN Robot <sv...@dev.null.org> ---
"steve_y" committed SVN revision 1642312 into trunk:
Issue 125495 - Awkward Chinese (ZH-TW) numbering suffix when importing RTF
do...
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #10 from Steve Yin <st...@gmail.com> ---
Hi Mark,
Any update for this issue?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #2 from Mark Hung <ma...@gmail.com> ---
Created attachment 83882
--> https://issues.apache.org/ooo/attachment.cgi?id=83882&action=edit
Sample test case.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #4 from Mark Hung <ma...@gmail.com> ---
Created attachment 83889
--> https://issues.apache.org/ooo/attachment.cgi?id=83889&action=edit
Screenshot for the effect of the patch in Linux.
The screenshot is taken under my environment, which is a Ubuntu 12 VM.
Note that this screenshot also include the fix of Chinese numbering issue of
125400, which is independent of this issue.
Uname -a list as follows:
Linux ubuntu 3.11.0-15-generic #25~precise1-Ubuntu SMP Thu Jan 30 17:39:31 UTC
2014 x86_64 x86_64 x86_64 GNU/Linux.
I haven't setup environment for Windows yet, so I can't verified this patch in
Windows.
Have you applied the patch successfully? I just found that I made diff under
svtools module instead of main or top directory.
Which environment are you testing?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
--- Comment #6 from Steve Yin <st...@gmail.com> ---
(In reply to Steve Yin from comment #5)
> (In reply to Mark Hung from comment #4)
> > Created attachment 83889 [details]
> > Screenshot for the effect of the patch in Linux.
> >
> > The screenshot is taken under my environment, which is a Ubuntu 12 VM.
> > Note that this screenshot also include the fix of Chinese numbering issue of
> > 125400, which is independent of this issue.
> >
> > Uname -a list as follows:
> > Linux ubuntu 3.11.0-15-generic #25~precise1-Ubuntu SMP Thu Jan 30 17:39:31
> > UTC 2014 x86_64 x86_64 x86_64 GNU/Linux.
> >
> > I haven't setup environment for Windows yet, so I can't verified this patch
> > in Windows.
> >
> > Have you applied the patch successfully? I just found that I made diff under
> > svtools module instead of main or top directory.
> > Which environment are you testing?
>
> Confirmed. I was misled by the first screenshot. I tested the sample on Win
> 7 Pro 64bit and Mac OS 10.7.5.
>
> The patch works for rtf/doc import/export except docx import.
For this issue only, the patch works. For the docx format, it should be fixed
by i125400
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125495] Awkward Chinese (ZH-TW) numbering suffix when
importing RTF document
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125495
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
CC| |orw@apache.org
Ever confirmed|0 |1
--- Comment #7 from Oliver-Rainer Wittmann <or...@apache.org> ---
First, I think we can change the issue status to confirmed as we are already
reviewing the applied patch.
Second, I will also have a look at the patch
Third, some questions:
- Does the patch also fixes the RTF export?
- Does the patch also fixes the WW8 (*.doc) import/export as Steve mentioned?
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.