[GitHub] kocolosk opened a new pull request #1066: Fix DB-specific compaction configuration (#1059)

[GitBox <gi...@apache.org>]

kocolosk opened a new pull request #1066: Fix DB-specific compaction configuration (#1059)
URL: https://github.com/apache/couchdb/pull/1066
 
 
   ## Overview
   
   The compaction daemon was checking for custom configurations using
   shard names directly, which meant that users who defined a config for
   a specific DB would not see it take effect.
   
   This patch introduces support for custom configurations for both
   databases *and* shards. An example of a shard config would be
   
   shards/00000000-1fffffff/foo.1512750761 = [{db_fragmentation, "70%"}]
   
   We don't anticipate that to be a typical usage pattern.
   
   ## Testing recommendations
   
   Create a clustered database ```foo``` and then configure a custom compaction rule for it:
   
   ```
   [compactions]
   foo = [{db_fragmentation, 10%}]
   ```
   
   We should add a test for this. The existing test suite only creates a node-local database which is why we missed this bug.
   
   ## Related Issues or Pull Requests
   
   Fixes #1059 
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services