You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/26 20:31:00 UTC
[jira] [Work logged] (BEAM-6518) Substring-matching bug in Python
metrics filtering
[ https://issues.apache.org/jira/browse/BEAM-6518?focusedWorklogId=190459&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-190459 ]
ASF GitHub Bot logged work on BEAM-6518:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/19 20:30
Start Date: 26/Jan/19 20:30
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7638: [BEAM-6518] fix python metric-querying bug
URL: https://github.com/apache/beam/pull/7638
Fixing a minor edge-case.
R: @mxm
CC: @ajamato
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 190459)
Time Spent: 10m
Remaining Estimate: 0h
> Substring-matching bug in Python metrics filtering
> --------------------------------------------------
>
> Key: BEAM-6518
> URL: https://issues.apache.org/jira/browse/BEAM-6518
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.9.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Trivial
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{[MetricResults._matches_sub_path|https://github.com/apache/beam/blob/5b46b02b49ca1c5c18682427a5a4a25596ca4287/sdks/python/apache_beam/metrics/metric.py#L152-L163]}} can be fooled into a false-negative if a path component before the one it is looking for is a superstring of the one it's looking for.
> It's not particularly likely to happen, but worth fixing anyway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)