You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/04/10 20:49:17 UTC

[GitHub] [tvm] Lunderberg opened a new pull request, #14562: [TIR][Driver] Move ShouldAnnotateEntryFunc logic into transform

Lunderberg opened a new pull request, #14562:
URL: https://github.com/apache/tvm/pull/14562

   Prior to this commit, the `MixedModulePassManager` determined whether the module should have its entry function annotated, while the `AnnotateEntryFunc` validates that this condition was upheld, duplicating the logic applied.  This commit moves the logic to `AnnotateEntryFunc`, which is unconditionally called from the `MixedModulePassManager`, but which is a no-op for cases where no annotation is required.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #14562: [TIR][Driver] Move ShouldAnnotateEntryFunc logic into transform

Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.

tvm-bot commented on PR #14562:
URL: https://github.com/apache/tvm/pull/14562#issuecomment-1502302864

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh, @shingjan <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] csullivan merged pull request #14562: [TIR][Driver] Move ShouldAnnotateEntryFunc logic into transform

Posted by "csullivan (via GitHub)" <gi...@apache.org>.

csullivan merged PR #14562:
URL: https://github.com/apache/tvm/pull/14562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org