You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dheerenmohta (via GitHub)" <gi...@apache.org> on 2026/09/09 10:50:14 UTC
[PR] Chart: Don't set deprecated git-sync branch/rev by default [airflow]
dheerenmohta opened a new pull request, #72792:
URL: https://github.com/apache/airflow/pull/72792
git-sync v4 (the chart's default image) treats the deprecated `--branch`/`--rev` flags as overriding `--ref` whenever they're set, not merely as a fallback — but the chart shipped non-empty `branch`/`rev` defaults (`v2-2-stable`/`HEAD`) alongside a default `ref`, so a stock deployment meant to pin a version via `ref` had it silently overridden.
This defaults `branch`/`rev` to unset and only renders their env vars when a user explicitly sets a non-null value, so a default v4 deployment is controlled by `ref` alone while git-sync v3 users who still rely on `branch`/`rev` are unaffected. A prior attempt (#42986) dropped v3 support outright and was rejected by maintainers as a breaking change reserved for a major version bump; this is additive and backward compatible instead.
closes: #42918
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Sonnet 5)
Generated-by: Claude Code (Sonnet 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: Don't set deprecated git-sync branch/rev by default [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #72792:
URL: https://github.com/apache/airflow/pull/72792#issuecomment-5608794350
In Helm Chart 2.0 (`main` branch), GitSync will be removed in favour of GitDagBundle, so there is no need for this PR to be merged there.
For the Helm Chart 1.2x line, it is a breaking change, so we can not merge it there.
Due to the above, closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart: Don't set deprecated git-sync branch/rev by default [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl closed pull request #72792: Chart: Don't set deprecated git-sync branch/rev by default
URL: https://github.com/apache/airflow/pull/72792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org