You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2009/11/09 17:11:14 UTC
svn commit: r834129 - in
/james/hupa/trunk/client/src/main/java/org/apache/hupa/client: ./ gin/ mvp/
mvp/place/ validation/
Author: norman
Date: Mon Nov 9 16:11:05 2009
New Revision: 834129
URL: http://svn.apache.org/viewvc?rev=834129&view=rev
Log:
Some more cleanup / move classes
Added:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/HupaPlaceManager.java
- copied, changed from r834092, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/HupaPlaceManager.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessageListPresenterPlace.java
- copied, changed from r834110, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessagePresenterPlace.java
- copied, changed from r834037, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/LoginPresenterPlace.java
- copied, changed from r834037, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MainPresenterPlace.java
- copied, changed from r834037, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MessageSendPresenterPlace.java
- copied, changed from r834092, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenterPlace.java
Removed:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/HupaWidgetDisplay.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/HupaPlaceManager.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenterPlace.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenterPlace.java
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/gin/HupaClientModule.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginView.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/gin/HupaClientModule.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/gin/HupaClientModule.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/gin/HupaClientModule.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/gin/HupaClientModule.java Mon Nov 9 16:11:05 2009
@@ -28,13 +28,9 @@
import org.apache.hupa.client.dnd.PagingScrollTableRowDragController;
import org.apache.hupa.client.mvp.AppPresenter;
import org.apache.hupa.client.mvp.AppView;
-import org.apache.hupa.client.mvp.HupaPlaceManager;
import org.apache.hupa.client.mvp.IMAPMessageListPresenter;
-import org.apache.hupa.client.mvp.IMAPMessageListPresenterPlace;
import org.apache.hupa.client.mvp.IMAPMessageListView;
import org.apache.hupa.client.mvp.IMAPMessagePresenter;
-import org.apache.hupa.client.mvp.LoginPresenterPlace;
-import org.apache.hupa.client.mvp.MainPresenterPlace;
import org.apache.hupa.client.mvp.MessageSendPresenter;
import org.apache.hupa.client.mvp.MessageSendView;
import org.apache.hupa.client.mvp.IMAPMessageView;
@@ -43,6 +39,10 @@
import org.apache.hupa.client.mvp.MainPresenter;
import org.apache.hupa.client.mvp.MainView;
import org.apache.hupa.client.mvp.MessageTableModel;
+import org.apache.hupa.client.mvp.place.HupaPlaceManager;
+import org.apache.hupa.client.mvp.place.IMAPMessageListPresenterPlace;
+import org.apache.hupa.client.mvp.place.LoginPresenterPlace;
+import org.apache.hupa.client.mvp.place.MainPresenterPlace;
import com.google.inject.Singleton;
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java Mon Nov 9 16:11:05 2009
@@ -23,10 +23,10 @@
import net.customware.gwt.dispatch.client.DispatchAsync;
import net.customware.gwt.presenter.client.EventBus;
+import net.customware.gwt.presenter.client.widget.WidgetDisplay;
import net.customware.gwt.presenter.client.widget.WidgetPresenter;
import org.apache.hupa.client.HupaCallback;
-import org.apache.hupa.client.HupaWidgetDisplay;
import org.apache.hupa.client.widgets.HasDialog;
import org.apache.hupa.shared.data.IMAPFolder;
import org.apache.hupa.shared.data.Message;
@@ -63,7 +63,7 @@
@SuppressWarnings("deprecation")
public class IMAPMessageListPresenter extends WidgetPresenter<IMAPMessageListPresenter.Display>{
- public interface Display extends HupaWidgetDisplay {
+ public interface Display extends WidgetDisplay {
public HasRowSelectionHandlers getDataTableSelection();
public HasPageLoadHandlers getDataTableLoad();
public void addTableListener(TableListener listener) ;
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenter.java Mon Nov 9 16:11:05 2009
@@ -23,11 +23,11 @@
import java.util.List;
import net.customware.gwt.presenter.client.EventBus;
+import net.customware.gwt.presenter.client.widget.WidgetDisplay;
import net.customware.gwt.presenter.client.widget.WidgetPresenter;
import org.apache.hupa.client.CachingDispatchAsync;
import org.apache.hupa.client.HupaCallback;
-import org.apache.hupa.client.HupaWidgetDisplay;
import org.apache.hupa.client.widgets.HasDialog;
import org.apache.hupa.client.widgets.HasURL;
import org.apache.hupa.shared.Util;
@@ -53,7 +53,7 @@
public class IMAPMessagePresenter extends WidgetPresenter<IMAPMessagePresenter.Display>{
- public interface Display extends HupaWidgetDisplay{
+ public interface Display extends WidgetDisplay{
public HasText getFrom();
public HasText getTo();
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenter.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenter.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenter.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenter.java Mon Nov 9 16:11:05 2009
@@ -21,11 +21,11 @@
import net.customware.gwt.dispatch.client.DispatchAsync;
import net.customware.gwt.presenter.client.EventBus;
+import net.customware.gwt.presenter.client.widget.WidgetDisplay;
import net.customware.gwt.presenter.client.widget.WidgetPresenter;
import org.apache.hupa.client.HupaCallback;
import org.apache.hupa.client.HupaConstants;
-import org.apache.hupa.client.HupaWidgetDisplay;
import org.apache.hupa.shared.events.LoginEvent;
import org.apache.hupa.shared.events.SessionExpireEvent;
import org.apache.hupa.shared.events.SessionExpireEventHandler;
@@ -49,13 +49,14 @@
public class LoginPresenter extends WidgetPresenter<LoginPresenter.Display>{
private HupaConstants constants = GWT.create(HupaConstants.class);
- public interface Display extends HupaWidgetDisplay{
+ public interface Display extends WidgetDisplay{
public HasClickHandlers getLoginClick();
public HasClickHandlers getResetClick();
public HasValue<String> getUserNameValue();
public HasValue<String> getPasswordValue();
public Focusable getUserNameFocus();
public HasText getErrorText();
+ public void setLoading(boolean loading);
}
private DispatchAsync dispatcher;
@@ -70,12 +71,17 @@
* Try to login the user
*/
private void doLogin() {
+ display.setLoading(true);
dispatcher.execute(new LoginUser(display.getUserNameValue().getValue(),display.getPasswordValue().getValue()), new HupaCallback<LoginUserResult>(dispatcher, eventBus, display) {
public void callback(LoginUserResult result) {
+ display.setLoading(false);
+
eventBus.fireEvent(new LoginEvent(result.getUser()));
doReset();
}
public void callbackError(Throwable caught) {
+ display.setLoading(false);
+
display.getErrorText().setText(constants.loginInvalid());
doReset();
}
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginView.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginView.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginView.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginView.java Mon Nov 9 16:11:05 2009
@@ -212,16 +212,13 @@
* (non-Javadoc)
* @see org.apache.hupa.client.HupaWidgetDisplay#startProcessing()
*/
- public void startProcessing() {
- loading.show();
- }
-
+ public void setLoading(boolean load) {
+ if (load) {
+ loading.show();
+ } else {
+ loading.hide();
- /*
- * (non-Javadoc)
- * @see org.apache.hupa.client.HupaWidgetDisplay#stopProcessing()
- */
- public void stopProcessing() {
- loading.hide();
+ }
}
+
}
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java Mon Nov 9 16:11:05 2009
@@ -131,9 +131,9 @@
public void decreaseUnseenMessageCount(IMAPFolder folder, int amount);
- public void startProcessing();
-
- public void stopProcessing();
+ public void setLoadingFolders(boolean loading);
+ public void setLoadingMessage(boolean loading);
+
}
private CachingDispatchAsync cachingDispatcher;
@@ -157,14 +157,14 @@
}
protected void loadTreeItems() {
- display.startProcessing();
+ display.setLoadingFolders(true);
cachingDispatcher.execute(new FetchFolders(), new HupaCallback<FetchFoldersResult>(cachingDispatcher, eventBus, display) {
public void callback(FetchFoldersResult result) {
display.bindTreeItems(createTreeNodes(result.getFolders()));
// disable
display.getDeleteEnable().setEnabled(false);
display.getRenameEnable().setEnabled(false);
- display.stopProcessing();
+ display.setLoadingFolders(false);
}
});
@@ -312,11 +312,14 @@
} else {
decreaseUnseen = false;
}
+
+ display.setLoadingMessage(true);
cachingDispatcher.executeWithCache(new GetMessageDetails(event.getFolder(), message.getUid()), new HupaCallback<GetMessageDetailsResult>(cachingDispatcher, eventBus, display) {
public void callback(GetMessageDetailsResult result) {
if (decreaseUnseen) {
eventBus.fireEvent(new DecreaseUnseenEvent(user, folder));
}
+ display.setLoadingMessage(false);
showMessage(user, folder, message, result.getMessageDetails());
}
});
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java Mon Nov 9 16:11:05 2009
@@ -101,6 +101,7 @@
private EnableHyperlink deleteFolderButton = new EnableHyperlink(constants.deleteFolder(), "");
private ConfirmDialogBox confirmFolderDeleteBox = new ConfirmDialogBox();
private Loading loader = new Loading(false);
+ private Loading messageLoader = new Loading(true);
private List<DropController> dropControllerList = new ArrayList<DropController>();
private EventBus bus;
private PagingScrollTableRowDragController controller;
@@ -191,6 +192,7 @@
});
hPanel.add(searchBox);
hPanel.add(searchButton);
+ hPanel.add(messageLoader);
barPanel.add(hPanel);
barPanel.setCellHorizontalAlignment(hPanel, HorizontalPanel.ALIGN_LEFT);
barPanel.add(loading);
@@ -300,25 +302,32 @@
return this;
}
+
/*
* (non-Javadoc)
- *
- * @see net.customware.gwt.presenter.client.Display#startProcessing()
+ * @see org.apache.hupa.client.mvp.MainPresenter.Display#setLoadingFolders(boolean)
*/
- public void startProcessing() {
- loader.show();
- panel.clear();
- panel.add(loader);
+ public void setLoadingFolders(boolean load) {
+ if (load) {
+ loader.show();
+ panel.clear();
+ panel.add(loader);
+ } else {
+ panel.clear();
+ panel.add(folderPanel);
+ }
}
/*
* (non-Javadoc)
- *
- * @see net.customware.gwt.presenter.client.Display#stopProcessing()
+ * @see org.apache.hupa.client.mvp.MainPresenter.Display#setLoadingMessage(boolean)
*/
- public void stopProcessing() {
- panel.clear();
- panel.add(folderPanel);
+ public void setLoadingMessage(boolean load) {
+ if (load) {
+ messageLoader.show();
+ } else {
+ messageLoader.hide();
+ }
}
/**
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java Mon Nov 9 16:11:05 2009
@@ -23,10 +23,10 @@
import net.customware.gwt.dispatch.client.DispatchAsync;
import net.customware.gwt.presenter.client.EventBus;
+import net.customware.gwt.presenter.client.widget.WidgetDisplay;
import net.customware.gwt.presenter.client.widget.WidgetPresenter;
import org.apache.hupa.client.HupaCallback;
-import org.apache.hupa.client.HupaWidgetDisplay;
import org.apache.hupa.client.validation.EmailListValidator;
import org.apache.hupa.client.validation.NotEmptyValidator;
import org.apache.hupa.shared.Util;
@@ -159,7 +159,7 @@
FORWARD
}
- public interface Display extends HupaWidgetDisplay {
+ public interface Display extends WidgetDisplay {
public HasText getFromText();
public HasText getToText();
public HasText getCcText();
@@ -171,6 +171,7 @@
public IUploader getUploader();
public void resetUploader();
public HasClickHandlers getBackButtonClick();
+ public void setLoading(boolean loading);
}
@Override
@@ -237,7 +238,7 @@
// TODO: good handling of error messages, and use an error widget instead of Window.alert
if (type.equals(Type.NEW)) {
- display.startProcessing();
+ display.setLoading(true);
dispatcher.execute(new SendMessage(message), new HupaCallback<GenericResult>(dispatcher, eventBus) {
public void callback(GenericResult result) {
@@ -247,12 +248,12 @@
} else {
Window.alert(result.getMessage());
}
- display.stopProcessing();
+ display.setLoading(false);
}
});
} else if(type.equals(Type.FORWARD)) {
- display.startProcessing();
+ display.setLoading(true);
dispatcher.execute(new ForwardMessage(message, folder, oldmessage.getUid()), new HupaCallback<GenericResult>(dispatcher, eventBus) {
public void callback(GenericResult result) {
@@ -262,12 +263,12 @@
} else {
Window.alert(result.getMessage());
}
- display.stopProcessing();
+ display.setLoading(false);
}
});
} else if(type.equals(Type.REPLY) || type.equals(Type.REPLY_ALL)) {
- display.startProcessing();
+ display.setLoading(true);
boolean replyAll = type.equals(Type.REPLY_ALL);
dispatcher.execute(new ReplyMessage(message, folder, oldmessage.getUid(), replyAll), new HupaCallback<GenericResult>(dispatcher, eventBus) {
@@ -278,7 +279,7 @@
} else {
Window.alert(result.getMessage());
}
- display.stopProcessing();
+ display.setLoading(false);
}
});
}
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendView.java Mon Nov 9 16:11:05 2009
@@ -186,24 +186,22 @@
return this;
}
- /*
- * (non-Javadoc)
- * @see net.customware.gwt.presenter.client.Display#startProcessing()
- */
- public void startProcessing() {
- sendProgress.show();
- sendButton.setEnabled(false);
- backButton.setEnabled(false);
- }
/*
* (non-Javadoc)
- * @see net.customware.gwt.presenter.client.Display#stopProcessing()
- */
- public void stopProcessing() {
- sendProgress.hide();
- sendButton.setEnabled(true);
- backButton.setEnabled(true);
+ * @see org.apache.hupa.client.mvp.MessageSendPresenter.Display#setLoading(boolean)
+ */
+ public void setLoading(boolean load) {
+ if (load) {
+ sendProgress.show();
+ sendButton.setEnabled(false);
+ backButton.setEnabled(false);
+ } else {
+ sendProgress.hide();
+ sendButton.setEnabled(true);
+ backButton.setEnabled(true);
+ }
+
}
/*
Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/HupaPlaceManager.java (from r834092, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/HupaPlaceManager.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/HupaPlaceManager.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/HupaPlaceManager.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/HupaPlaceManager.java&r1=834092&r2=834129&rev=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/HupaPlaceManager.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/HupaPlaceManager.java Mon Nov 9 16:11:05 2009
@@ -17,13 +17,18 @@
* under the License. *
****************************************************************/
-package org.apache.hupa.client.mvp;
+package org.apache.hupa.client.mvp.place;
import com.google.inject.Inject;
import net.customware.gwt.presenter.client.EventBus;
import net.customware.gwt.presenter.client.place.DefaultPlaceManager;
+/**
+ * PlaceManager implementation for Hupa
+ *
+ *
+ */
public class HupaPlaceManager extends DefaultPlaceManager{
@Inject
Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessageListPresenterPlace.java (from r834110, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenterPlace.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessageListPresenterPlace.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessageListPresenterPlace.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenterPlace.java&r1=834110&r2=834129&rev=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenterPlace.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessageListPresenterPlace.java Mon Nov 9 16:11:05 2009
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations *
* under the License. *
****************************************************************/
-package org.apache.hupa.client.mvp;
+package org.apache.hupa.client.mvp.place;
+
+import org.apache.hupa.client.mvp.IMAPMessageListPresenter;
import com.google.inject.Inject;
import com.google.inject.Provider;
Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessagePresenterPlace.java (from r834037, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenterPlace.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessagePresenterPlace.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessagePresenterPlace.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenterPlace.java&r1=834037&r2=834129&rev=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessagePresenterPlace.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/IMAPMessagePresenterPlace.java Mon Nov 9 16:11:05 2009
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations *
* under the License. *
****************************************************************/
-package org.apache.hupa.client.mvp;
+package org.apache.hupa.client.mvp.place;
+
+import org.apache.hupa.client.mvp.IMAPMessagePresenter;
import com.google.inject.Inject;
import com.google.inject.Provider;
Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/LoginPresenterPlace.java (from r834037, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenterPlace.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/LoginPresenterPlace.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/LoginPresenterPlace.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenterPlace.java&r1=834037&r2=834129&rev=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/LoginPresenterPlace.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/LoginPresenterPlace.java Mon Nov 9 16:11:05 2009
@@ -17,7 +17,9 @@
* under the License. *
****************************************************************/
-package org.apache.hupa.client.mvp;
+package org.apache.hupa.client.mvp.place;
+
+import org.apache.hupa.client.mvp.LoginPresenter;
import com.google.inject.Inject;
import com.google.inject.Provider;
Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MainPresenterPlace.java (from r834037, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenterPlace.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MainPresenterPlace.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MainPresenterPlace.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenterPlace.java&r1=834037&r2=834129&rev=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenterPlace.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MainPresenterPlace.java Mon Nov 9 16:11:05 2009
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations *
* under the License. *
****************************************************************/
-package org.apache.hupa.client.mvp;
+package org.apache.hupa.client.mvp.place;
+
+import org.apache.hupa.client.mvp.MainPresenter;
import com.google.inject.Inject;
import com.google.inject.Provider;
Copied: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MessageSendPresenterPlace.java (from r834092, james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenterPlace.java)
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MessageSendPresenterPlace.java?p2=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MessageSendPresenterPlace.java&p1=james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenterPlace.java&r1=834092&r2=834129&rev=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenterPlace.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/place/MessageSendPresenterPlace.java Mon Nov 9 16:11:05 2009
@@ -16,7 +16,9 @@
* specific language governing permissions and limitations *
* under the License. *
****************************************************************/
-package org.apache.hupa.client.mvp;
+package org.apache.hupa.client.mvp.place;
+
+import org.apache.hupa.client.mvp.MessageSendPresenter;
import com.google.inject.Inject;
import com.google.inject.Provider;
Modified: james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
URL: http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java?rev=834129&r1=834128&r2=834129&view=diff
==============================================================================
--- james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java (original)
+++ james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java Mon Nov 9 16:11:05 2009
@@ -28,7 +28,7 @@
/**
* Validator which handles the validation of Email Lists. Email addresses
- * needs to be commaseperated
+ * needs to be comma separated
*
*
*/
@@ -76,6 +76,12 @@
return true;
}
+ /**
+ * Checks if the given value is a valid emailaddress
+ *
+ * @param email
+ * @return isValid
+ */
private boolean isValidAddress(String email) {
return email.matches(emailRegex);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org