You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jiangzhx (via GitHub)" <gi...@apache.org> on 2023/03/01 09:00:29 UTC
[GitHub] [arrow-datafusion] jiangzhx opened a new pull request, #5438: Update README.md fix [DataFusion] links
jiangzhx opened a new pull request, #5438:
URL: https://github.com/apache/arrow-datafusion/pull/5438
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5438: Update README.md fix [DataFusion] links
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #5438:
URL: https://github.com/apache/arrow-datafusion/pull/5438#discussion_r1121705026
##########
datafusion-cli/README.md:
##########
@@ -19,7 +19,7 @@
# DataFusion Command-line Interface
-[DataFusion](df) is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format.
+[DataFusion]\(df\) is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format.
Review Comment:
```suggestion
[DataFusion](https://github.com/apache/arrow-datafusion) is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5438: Update README.md fix [DataFusion] links
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5438:
URL: https://github.com/apache/arrow-datafusion/pull/5438#issuecomment-1450150333
Benchmark runs are scheduled for baseline = 793feda23817d10b765dcee468d96b6fd5276ea6 and contender = c4b895822a02d28d9adcd42112cc2604dde5d0e1. c4b895822a02d28d9adcd42112cc2604dde5d0e1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/518a91c6f92247d3abae53e9310e9585...bfa8fdd2d8424bc09ccaf799adea02e6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/54e337a8c9324548a140c66bf44bddbf...31dbe55bb88a430e9fef8d99eebb1424/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/0801a47693884809b0db32b1e3cbbc1b...8c0736b67b344f5c9b61d50067c3d5c2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5df07a461e4343e29d03be327107867c...d8d611bb731845f0b68b821c442d81b9/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener merged pull request #5438: Update README.md fix [DataFusion] links
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #5438:
URL: https://github.com/apache/arrow-datafusion/pull/5438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #5438: Update README.md fix [DataFusion] links
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on code in PR #5438:
URL: https://github.com/apache/arrow-datafusion/pull/5438#discussion_r1121560423
##########
datafusion-cli/README.md:
##########
@@ -19,7 +19,7 @@
# DataFusion Command-line Interface
-[DataFusion](df) is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format.
+[DataFusion][df] is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format.
Review Comment:
```suggestion
[DataFusion]\(df\) is an extensible query execution framework, written in Rust, that uses Apache Arrow as its in-memory format.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org