You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/29 08:29:32 UTC

[GitHub] [spark] yaooqinn commented on a change in pull request #26291: [SPARK-29629][SQL] Support typed integer literal expression

yaooqinn commented on a change in pull request #26291: [SPARK-29629][SQL] Support typed integer literal expression
URL: https://github.com/apache/spark/pull/26291#discussion_r339941853
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
 ##########
 @@ -36,3 +36,5 @@ select date '2001-10-01' - 7;
 select date '2001-10-01' - date '2001-09-28';
 select date'2020-01-01' - timestamp'2019-10-06 10:11:12.345678';
 select timestamp'2019-10-06 10:11:12.345678' - date'2020-01-01';
+select date '2001-09-28' + integer '7';
 
 Review comment:
   thanks for your review. updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org