You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2021/03/03 15:41:58 UTC
[GitHub] [cassandra-dtest] adelapena commented on a change in pull request #112: CASSANDRA-16181 - 4.0 Quality: Replication Test Audit
adelapena commented on a change in pull request #112:
URL: https://github.com/apache/cassandra-dtest/pull/112#discussion_r586524216
##########
File path: conftest.py
##########
@@ -448,10 +449,10 @@ def _skip_ported_msg(current_running_version, ported_from_version):
@pytest.fixture(autouse=True)
def fixture_ported_to_in_jvm(request, fixture_dtest_setup):
"""
- Adds a new mark called 'ported_to_in_jvm' which denotes that a test was ported to jvm-dtest.
+ Adds a new mark called 'ported_to_in_jvm' which denotes that a test was ported to an in-JVM dtest.
- As of this point in time there are weaknesses of jvm-dtest which require these tests to still
- be run in the cases not covered by jvm-dtest; namely vnode.
+ In-JVM dtests do not currently support running with compression or vnodes, so tests that use this annotation will
Review comment:
It seems that Python dtests aren't run with different compression options anymore, so we can remove the mention of compression, especially since the fixture code doesn't do anything about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org