You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 04:00:29 UTC

[GitHub] [flink] Myasuka commented on a change in pull request #12153: [FLINK-16966][metrics][infuxdb] Convert InfluxDB reporter to plugin

Myasuka commented on a change in pull request #12153:
URL: https://github.com/apache/flink/pull/12153#discussion_r425552234



##########
File path: flink-metrics/flink-metrics-influxdb/src/main/java/org/apache/flink/metrics/influxdb/InfluxdbReporterFactory.java
##########
@@ -0,0 +1,14 @@
+package org.apache.flink.metrics.influxdb;
+
+import org.apache.flink.metrics.reporter.MetricReporter;
+import org.apache.flink.metrics.reporter.MetricReporterFactory;
+
+import java.util.Properties;
+
+public class InfluxdbReporterFactory implements MetricReporterFactory {

Review comment:
       This class miss a javadoc and should not pass during checkstyle.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org