[GitHub] [beam] youngoli commented on a change in pull request #17045: [BEAM-10976] Bundle finalization: E2E support

[GitBox <gi...@apache.org>]

youngoli commented on a change in pull request #17045:
URL: https://github.com/apache/beam/pull/17045#discussion_r830423680



##########
File path: sdks/go/pkg/beam/core/funcx/fn.go
##########
@@ -415,7 +432,7 @@ func SubReturns(list []ReturnParam, indices ...int) []ReturnParam {
 }
 
 // The order of present parameters and return values must be as follows:
-// func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)
+// func(FnContext?, FnPane?, FnWindow?, FnEventTime?, FnType?, FnRTracker?, FnBundleFinalization?, (FnValue, SideInput*)?, FnEmit*) (RetEventTime?, RetOutput?, RetError?)

Review comment:
       Nit: Personally I think BundleFinalization should come before the RTracker, because the restriction is basically part of the main input so I feel it should come right before the main input. Not something I'd block on, just preference.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org