You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/06 01:51:24 UTC
[GitHub] [incubator-doris] morningman commented on a diff in pull request #8848: [Refactor][httpv2]remove http v1 code
morningman commented on code in PR #8848:
URL: https://github.com/apache/incubator-doris/pull/8848#discussion_r843393197
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/IllegalArgException.java:
##########
@@ -14,21 +14,20 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
-
-package org.apache.doris.http;
+package org.apache.doris.httpv2;
public class IllegalArgException extends Exception {
- private static final long serialVersionUID = 3344697787301861667L;
+ private static final long serialVersionUID = 3344697787301861667L;
- public IllegalArgException() {
- super("");
- }
+ public IllegalArgException() {
+ super("");
Review Comment:
Code format
4 spaces
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/entity/RestBaseResult.java:
##########
@@ -14,34 +14,34 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
-
-package org.apache.doris.http.rest;
+package org.apache.doris.httpv2.entity;
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
// Base restful result
public class RestBaseResult {
- private static final RestBaseResult OK = new RestBaseResult();
- public ActionStatus status;
- public String msg;
- public RestBaseResult() {
- status = ActionStatus.OK;
- msg = "Success";
- }
+ private static final RestBaseResult OK = new RestBaseResult();
+ public ActionStatus status;
+ public String msg;
+
+ public RestBaseResult() {
+ status = ActionStatus.OK;
+ msg = "Success";
+ }
- public RestBaseResult(String msg) {
- status = ActionStatus.FAILED;
- this.msg = msg;
- }
+ public RestBaseResult(String msg) {
+ status = ActionStatus.FAILED;
Review Comment:
4 spaces
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/entity/RestResult.java:
##########
@@ -15,31 +15,32 @@
// specific language governing permissions and limitations
// under the License.
-package org.apache.doris.http.rest;
+package org.apache.doris.httpv2.entity;
import java.util.Map;
import com.google.common.collect.Maps;
import com.google.gson.Gson;
public class RestResult extends RestBaseResult {
- private Map<String, Object> resultMap;
- public RestResult() {
- super();
- resultMap = Maps.newHashMap();
- }
+ private Map<String, Object> resultMap;
- public void addResultEntry(String key, Object value) {
- resultMap.put(key, value);
- }
+ public RestResult() {
+ super();
Review Comment:
4 spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org