You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Igor Belakovskiy <bu...@alum.mit.edu> on 2012/01/18 20:19:23 UTC
Review Request: opensearch implementation in sample container doesn't work.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/
-----------------------------------------------------------
Review request for shindig and Dan Dumont.
Summary
-------
gadgets.io.makeRequest doesn't work in the container. Change the code to use osapi.http.get. Changed the feature.xml for xmlutils to expose the xml utils to the container, rather than replicating existing code. JIRA: https://issues.apache.org/jira/browse/SHINDIG-1682
Diffs
-----
trunk/content/samplecontainer/examples/commoncontainer/index.html 1232531
trunk/content/samplecontainer/examples/commoncontainer/search.js 1232531
trunk/features/src/main/javascript/features/xmlutil/feature.xml 1232531
Diff: https://reviews.apache.org/r/3528/diff
Testing
-------
manual testing
Thanks,
Igor
Re: Review Request: opensearch implementation in sample container doesn't
work.
Posted by dd...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/
-----------------------------------------------------------
(Updated June 26, 2012, 6:12 p.m.)
Review request for shindig and Dan Dumont.
Description
-------
gadgets.io.makeRequest doesn't work in the container. Change the code to use osapi.http.get. Changed the feature.xml for xmlutils to expose the xml utils to the container, rather than replicating existing code. JIRA: https://issues.apache.org/jira/browse/SHINDIG-1682
This addresses bug SHINDIG-1682.
https://issues.apache.org/jira/browse/SHINDIG-1682
Diffs
-----
trunk/content/samplecontainer/examples/commoncontainer/index.html 1232531
trunk/content/samplecontainer/examples/commoncontainer/search.js 1232531
trunk/features/src/main/javascript/features/xmlutil/feature.xml 1232531
Diff: https://reviews.apache.org/r/3528/diff/
Testing
-------
manual testing
Thanks,
Igor Belakovskiy
Re: Review Request: opensearch implementation in sample container doesn't
work.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/#review4542
-----------------------------------------------------------
Ship it!
Committed r1235009. Please link the Jira in the bugs section of the review and close the review.
- Dan
On 2012-01-23 20:26:52, Igor Belakovskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3528/
> -----------------------------------------------------------
>
> (Updated 2012-01-23 20:26:52)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Summary
> -------
>
> gadgets.io.makeRequest doesn't work in the container. Change the code to use osapi.http.get. Changed the feature.xml for xmlutils to expose the xml utils to the container, rather than replicating existing code. JIRA: https://issues.apache.org/jira/browse/SHINDIG-1682
>
>
> Diffs
> -----
>
> trunk/content/samplecontainer/examples/commoncontainer/index.html 1232531
> trunk/content/samplecontainer/examples/commoncontainer/search.js 1232531
> trunk/features/src/main/javascript/features/xmlutil/feature.xml 1232531
>
> Diff: https://reviews.apache.org/r/3528/diff
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Igor
>
>
Re: Review Request: opensearch implementation in sample container doesn't
work.
Posted by Igor Belakovskiy <bu...@alum.mit.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/
-----------------------------------------------------------
(Updated 2012-01-23 20:26:52.530429)
Review request for shindig and Dan Dumont.
Changes
-------
Removed white space per review
Summary
-------
gadgets.io.makeRequest doesn't work in the container. Change the code to use osapi.http.get. Changed the feature.xml for xmlutils to expose the xml utils to the container, rather than replicating existing code. JIRA: https://issues.apache.org/jira/browse/SHINDIG-1682
Diffs (updated)
-----
trunk/content/samplecontainer/examples/commoncontainer/index.html 1232531
trunk/content/samplecontainer/examples/commoncontainer/search.js 1232531
trunk/features/src/main/javascript/features/xmlutil/feature.xml 1232531
Diff: https://reviews.apache.org/r/3528/diff
Testing
-------
manual testing
Thanks,
Igor
Re: Review Request: opensearch implementation in sample container doesn't
work.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3528/#review4443
-----------------------------------------------------------
Ship it!
LGTM
trunk/content/samplecontainer/examples/commoncontainer/search.js
<https://reviews.apache.org/r/3528/#comment9975>
nit: whitespace
- Dan
On 2012-01-18 19:19:23, Igor Belakovskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3528/
> -----------------------------------------------------------
>
> (Updated 2012-01-18 19:19:23)
>
>
> Review request for shindig and Dan Dumont.
>
>
> Summary
> -------
>
> gadgets.io.makeRequest doesn't work in the container. Change the code to use osapi.http.get. Changed the feature.xml for xmlutils to expose the xml utils to the container, rather than replicating existing code. JIRA: https://issues.apache.org/jira/browse/SHINDIG-1682
>
>
> Diffs
> -----
>
> trunk/content/samplecontainer/examples/commoncontainer/index.html 1232531
> trunk/content/samplecontainer/examples/commoncontainer/search.js 1232531
> trunk/features/src/main/javascript/features/xmlutil/feature.xml 1232531
>
> Diff: https://reviews.apache.org/r/3528/diff
>
>
> Testing
> -------
>
> manual testing
>
>
> Thanks,
>
> Igor
>
>