You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/05/23 15:16:17 UTC
[GitHub] [kylin] codecov-io commented on issue #652: Removed duplicate code
in KylinMeta
codecov-io commented on issue #652: Removed duplicate code in KylinMeta
URL: https://github.com/apache/kylin/pull/652#issuecomment-495262616
# [Codecov](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=h1) Report
> Merging [#652](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b48de90d046bfbef30917149e9c3426c6a7365cc?src=pr&el=desc) will **increase** coverage by `0.1%`.
> The diff coverage is `9.09%`.
[](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #652 +/- ##
==========================================
+ Coverage 25.7% 25.8% +0.1%
- Complexity 5976 6011 +35
==========================================
Files 1382 1382
Lines 82144 82147 +3
Branches 11509 11511 +2
==========================================
+ Hits 21112 21198 +86
+ Misses 58985 58903 -82
+ Partials 2047 2046 -1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/kylin/jdbc/KylinMeta.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbk1ldGEuamF2YQ==) | `53.84% <9.09%> (+3.84%)` | `15 <1> (+1)` | :arrow_up: |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
| [...eam/core/storage/columnar/DataSegmentFragment.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvRGF0YVNlZ21lbnRGcmFnbWVudC5qYXZh) | `57.37% <0%> (-1.64%)` | `17% <0%> (-1%)` | |
| [...a/org/apache/kylin/common/util/HiveCmdBuilder.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hpdmVDbWRCdWlsZGVyLmphdmE=) | `81.08% <0%> (-1.12%)` | `12% <0%> (ø)` | |
| [...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh) | `75.38% <0%> (-1.03%)` | `27% <0%> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.6% <0%> (-0.61%)` | `7% <0%> (ø)` | |
| [...a/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL01SSGl2ZURpY3RVdGlsLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...apache/kylin/source/hive/CreateMrHiveDictStep.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZU1ySGl2ZURpY3RTdGVwLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...lin/source/hive/CreateFlatHiveTableByLivyStep.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NyZWF0ZUZsYXRIaXZlVGFibGVCeUxpdnlTdGVwLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...urce/hive/RedistributeFlatHiveTableByLivyStep.java](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL1JlZGlzdHJpYnV0ZUZsYXRIaXZlVGFibGVCeUxpdnlTdGVwLmphdmE=) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/kylin/pull/652/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=footer). Last update [b48de90...efd4ad4](https://codecov.io/gh/apache/kylin/pull/652?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services