You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by na...@apache.org on 2017/04/18 22:05:37 UTC
samza git commit: SAMZA-1182 : Disable flaky tests in TestAsyncRunLoop
Repository: samza
Updated Branches:
refs/heads/master e95088d96 -> 2e602c46f
SAMZA-1182 : Disable flaky tests in TestAsyncRunLoop
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Reviewers: Navina Ramesh <na...@apache.org>
Closes #126 from shanthoosh/disable_all_async_run_loop_tests
Project: http://git-wip-us.apache.org/repos/asf/samza/repo
Commit: http://git-wip-us.apache.org/repos/asf/samza/commit/2e602c46
Tree: http://git-wip-us.apache.org/repos/asf/samza/tree/2e602c46
Diff: http://git-wip-us.apache.org/repos/asf/samza/diff/2e602c46
Branch: refs/heads/master
Commit: 2e602c46f66a08e39f944c47a2335a3ad00e0364
Parents: e95088d
Author: Shanthoosh Venkataraman <sv...@linkedin.com>
Authored: Tue Apr 18 15:05:27 2017 -0700
Committer: nramesh <nr...@linkedin.com>
Committed: Tue Apr 18 15:05:27 2017 -0700
----------------------------------------------------------------------
.../org/apache/samza/task/TestAsyncRunLoop.java | 27 ++++++++++----------
1 file changed, 14 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/samza/blob/2e602c46/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
----------------------------------------------------------------------
diff --git a/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java b/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
index d19e5dd..f70ad00 100644
--- a/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
+++ b/samza-core/src/test/java/org/apache/samza/task/TestAsyncRunLoop.java
@@ -59,6 +59,7 @@ import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.atLeastOnce;
+// TODO(spvenkat) SAMZA-1183: Fix all commented out tests.
public class TestAsyncRunLoop {
// Immutable objects shared by all test methods.
private final ExecutorService executor = null;
@@ -201,7 +202,7 @@ public class TestAsyncRunLoop {
when(consumerMultiplexer.pollIntervalMs()).thenReturn(10);
}
- @Test
+ //@Test
public void testProcessMultipleTasks() throws Exception {
CountDownLatch task0ProcessedMessages = new CountDownLatch(1);
CountDownLatch task1ProcessedMessages = new CountDownLatch(1);
@@ -232,7 +233,7 @@ public class TestAsyncRunLoop {
assertEquals(2L, containerMetrics.processes().getCount());
}
- @Test
+ //@Test
public void testProcessInOrder() throws Exception {
CountDownLatch task0ProcessedMessages = new CountDownLatch(2);
CountDownLatch task1ProcessedMessages = new CountDownLatch(1);
@@ -286,7 +287,7 @@ public class TestAsyncRunLoop {
};
}
- @Test
+ //@Test
public void testProcessOutOfOrder() throws Exception {
int maxMessagesInFlight = 2;
@@ -320,7 +321,7 @@ public class TestAsyncRunLoop {
assertEquals(3L, containerMetrics.processes().getCount());
}
- @Test
+ //@Test
public void testWindow() throws Exception {
TestTask task0 = new TestTask(true, true, false, null);
TestTask task1 = new TestTask(true, false, true, null);
@@ -341,7 +342,7 @@ public class TestAsyncRunLoop {
assertEquals(4, task1.windowCount);
}
- @Test
+ //@Test
public void testCommitSingleTask() throws Exception {
CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
@@ -371,7 +372,7 @@ public class TestAsyncRunLoop {
verify(offsetManager, never()).checkpoint(taskName1);
}
- @Test
+ //@Test
public void testCommitAllTasks() throws Exception {
CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
@@ -401,7 +402,7 @@ public class TestAsyncRunLoop {
verify(offsetManager).checkpoint(taskName1);
}
- @Test
+ //@Test
public void testShutdownOnConsensus() throws Exception {
CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
@@ -438,7 +439,7 @@ public class TestAsyncRunLoop {
assertEquals(2L, containerMetrics.processes().getCount());
}
- @Test
+ //@Test
public void testEndOfStreamWithMultipleTasks() throws Exception {
CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
@@ -476,7 +477,7 @@ public class TestAsyncRunLoop {
assertEquals(2L, containerMetrics.processes().getCount());
}
- @Test
+ //@Test
public void testEndOfStreamWithOutOfOrderProcess() throws Exception {
int maxMessagesInFlight = 2;
@@ -518,7 +519,7 @@ public class TestAsyncRunLoop {
assertEquals(3L, containerMetrics.processes().getCount());
}
- @Test
+ //@Test
public void testEndOfStreamCommitBehavior() throws Exception {
CountDownLatch task0ProcessedMessagesLatch = new CountDownLatch(1);
CountDownLatch task1ProcessedMessagesLatch = new CountDownLatch(1);
@@ -556,7 +557,7 @@ public class TestAsyncRunLoop {
}
// TODO: Add assertions.
- @Test
+ //@Test
public void testEndOfStreamOffsetManagement() throws Exception {
//explicitly configure to disable commits inside process or window calls and invoke commit from end of stream
TestTask mockStreamTask1 = new TestTask(true, false, false, null);
@@ -614,7 +615,7 @@ public class TestAsyncRunLoop {
runLoop.run();
}
- @Test
+ //@Test
public void testCommitBehaviourWhenAsyncCommitIsEnabled() throws InterruptedException {
int maxMessagesInFlight = 3;
TestTask task0 = new TestTask(true, true, false, null,
@@ -671,7 +672,7 @@ public class TestAsyncRunLoop {
assertEquals(0, task1.committed);
}
- @Test
+ //@Test
public void testProcessBehaviourWhenAsyncCommitIsEnabled() throws InterruptedException {
int maxMessagesInFlight = 2;
TestTask task0 = new TestTask(true, true, false, null, maxMessagesInFlight);