You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/06 02:34:04 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1373: Add !init.d to the top level of .gitignore
xiaoxiang781216 opened a new pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373
Since init.d is normally used to hold the initial shell scripts
## Summary
See the disussion here: https://github.com/apache/incubator-nuttx/issues/1363
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1373: board/sim: Don't ignore any files under src/etc/ folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-654571841
> @xiaoxiang781216 I'll merge this in, but I am thinking of only backporting #1376 if we merge that since it will resolve the issue directly for this release while this will fix future issues. Does that sound reasonable?
Yes, this patch isn't critcial as before with #1376.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1373: Add !init.d to the top level of .gitignore
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-654007850
> No. we have `etc/init.d/rcS` I am suggesting that maybe we should be doing something like `!*` in the `etc` folder. This is a filesystem for the device I am not sure why we would apply the code base artifact rules to them.
But this will package .gitignore into the generated file system image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1373: Add !init.d to the top level of .gitignore
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-654005125
No. we have `etc/init.d/rcS` I am suggesting that maybe we should be doing something like `!*` in the `etc` folder. This is a filesystem for the device I am not sure why we would apply the code base artifact rules to them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1373: Add !init.d to the top level of .gitignore
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-653992454
Wouldn't it be better to disable all the gitignore rules in the folder that we are packing up in the binary? Otherwise we are going to be calling out random files in the top level gitignore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1373: board/sim: Don't ignore any files under src/etc/ folder
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-654039292
I move the pattern to the parent folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1373: board/sim: Don't ignore any files under src/etc/ folder
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-654563209
@xiaoxiang781216 I'll merge this in, but I am thinking of only backporting #1376 if we merge that since it will resolve the issue directly for this release while this will fix future issues. Does that sound reasonable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1373: Add !init.d to the top level of .gitignore
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373#issuecomment-653999858
But init.d is the standard POSIX folder, do you want each board directory add "!.init.d" individually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #1373: board/sim: Don't ignore any files under src/etc/ folder
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #1373:
URL: https://github.com/apache/incubator-nuttx/pull/1373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org