[GitHub] [spark] srielau commented on a diff in pull request #39963: [SPARK-42324][SQL] Assign name to _LEGACY_ERROR_TEMP_1001

["srielau (via GitHub)" <gi...@apache.org>]

srielau commented on code in PR #39963:
URL: https://github.com/apache/spark/pull/39963#discussion_r1103149937


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
     ],
     "sqlState" : "42883"
   },
+  "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+    "message" : [
+      "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."

Review Comment:
   USING column `c0` cannot be resolved on the left side of the join. The left-side columns: [c1, c2, c3].
   
   Do we use the suggestion code we have for UNRSOLVED_COLUMN>? We should NOT pump out all columns.
   ```suggestion
         "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<suggestion>]."
   ```



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -1537,6 +1537,12 @@
     ],
     "sqlState" : "42883"
   },
+  "UNRESOLVED_USING_COLUMN_FOR_JOIN" : {
+    "message" : [
+      "USING column <colName> cannot be resolved on the <side> side of the join. The <side>-side columns: [<plan>]."
+    ],
+    "sqlState" : "42877"

Review Comment:
   42877 is for illegally qualified columns e.g. USING (t.c1) (a syntax error for us)
   ```suggestion
       "sqlState" : "42703"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org