You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sihuazhou <gi...@git.apache.org> on 2018/03/19 11:52:05 UTC
[GitHub] flink pull request #5716: [FLINK-9022][state] fix resource release in Stream...
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/5716
[FLINK-9022][state] fix resource release in StreamTaskStateInitializerImpl.streamOperatorStateContext()
## What is the purpose of the change
This PR fixes the bug in `StreamTaskStateInitializerImpl.streamOperatorStateContext()` related to resource releasing.
## Brief change log
- fix resource release in StreamTaskStateInitializerImpl.streamOperatorStateContext()
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink fix_resource_close_in_StreamTaskStateInitializerImpl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5716.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5716
----
commit e5591005f8470f24bae30670c2c9094d13b9f35c
Author: sihuazhou <su...@...>
Date: 2018-03-19T11:48:32Z
fix resource release in StreamTaskStateInitializerImpl.streamOperatorStateContext()
----
---
[GitHub] flink issue #5716: [FLINK-9022][state] fix resource release in StreamTaskSta...
Posted by sihuazhou <gi...@git.apache.org>.
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5716
@StefanRRichter Could you please have a look at this? I think this should be fixed for 1.5.
---
[GitHub] flink issue #5716: [FLINK-9022][state] fix resource release in StreamTaskSta...
Posted by sihuazhou <gi...@git.apache.org>.
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5716
Strange...the Travis failed and the failed is related to `YarnClusterDescriptorTest`, but it seems not related to this PR...
---
[GitHub] flink pull request #5716: [FLINK-9022][state] fix resource release in Stream...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5716
---
[GitHub] flink issue #5716: [FLINK-9022][state] fix resource release in StreamTaskSta...
Posted by sihuazhou <gi...@git.apache.org>.
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/5716
Hi @tillrohrmann I think maybe stefan is too busy with the testing work for 1.5 currently, could you please have a look at this? This is obvious bug that need to be addressed.
---