You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by "Shaofeng SHI (JIRA)" <ji...@apache.org> on 2017/08/20 09:47:00 UTC

[jira] [Commented] (KYLIN-2796) Remove the legacy "statisticsenabled" codes in FactDistinctColumnsJob

    [ https://issues.apache.org/jira/browse/KYLIN-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134360#comment-16134360 ] 

Shaofeng SHI commented on KYLIN-2796:
-------------------------------------

Just found the MR Engine V1 (MR_V1) still use this. Unless we remove MR Engine V1, couldn't remove the legacy code. Open KYLIN-2797 to propose to remove V1 engine.

> Remove the legacy "statisticsenabled" codes in FactDistinctColumnsJob
> ---------------------------------------------------------------------
>
>                 Key: KYLIN-2796
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2796
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Job Engine
>            Reporter: Shaofeng SHI
>            Assignee: Shaofeng SHI
>             Fix For: v2.2.0
>
>
> There are some legacy codes in FactDistinctColumnsJob.java which was for the compitable with v1.3 and before's Cube, like the checking for whether need collect cube statistics. In 1.5 and later, this option is alreays be true, removing the redundant check will make code clean.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)