You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by co...@apache.org on 2016/07/21 10:25:05 UTC
directory-kerby git commit: Unset Critical flag for Certificate
Extensions by default
Repository: directory-kerby
Updated Branches:
refs/heads/trunk 051be3719 -> 624d65348
Unset Critical flag for Certificate Extensions by default
Project: http://git-wip-us.apache.org/repos/asf/directory-kerby/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-kerby/commit/624d6534
Tree: http://git-wip-us.apache.org/repos/asf/directory-kerby/tree/624d6534
Diff: http://git-wip-us.apache.org/repos/asf/directory-kerby/diff/624d6534
Branch: refs/heads/trunk
Commit: 624d65348443a9b8c6f7afaa1a2645b7b39b0fc1
Parents: 051be37
Author: Colm O hEigeartaigh <co...@apache.org>
Authored: Thu Jul 21 11:24:44 2016 +0100
Committer: Colm O hEigeartaigh <co...@apache.org>
Committed: Thu Jul 21 11:24:44 2016 +0100
----------------------------------------------------------------------
.../src/test/java/org/apache/kerby/kerberos/kerb/CryptoTest.java | 1 -
.../src/main/java/org/apache/kerby/x509/type/Extension.java | 3 ---
kerby-pkix/src/test/java/org/apache/kerby/cms/ExtensionTest.java | 1 +
3 files changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/624d6534/kerby-kerb/kerb-common/src/test/java/org/apache/kerby/kerberos/kerb/CryptoTest.java
----------------------------------------------------------------------
diff --git a/kerby-kerb/kerb-common/src/test/java/org/apache/kerby/kerberos/kerb/CryptoTest.java b/kerby-kerb/kerb-common/src/test/java/org/apache/kerby/kerberos/kerb/CryptoTest.java
index 691b6b7..af6d7a2 100644
--- a/kerby-kerb/kerb-common/src/test/java/org/apache/kerby/kerberos/kerb/CryptoTest.java
+++ b/kerby-kerb/kerb-common/src/test/java/org/apache/kerby/kerberos/kerb/CryptoTest.java
@@ -37,7 +37,6 @@ import org.junit.Test;
public class CryptoTest {
@Test
- @org.junit.Ignore
public void testCertificateLoading() throws Exception {
// Load cert
List<Certificate> certs = CertificateHelper.loadCerts("kdccerttest.pem");
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/624d6534/kerby-pkix/src/main/java/org/apache/kerby/x509/type/Extension.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/Extension.java b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/Extension.java
index 449e92c..21245ef 100644
--- a/kerby-pkix/src/main/java/org/apache/kerby/x509/type/Extension.java
+++ b/kerby-pkix/src/main/java/org/apache/kerby/x509/type/Extension.java
@@ -54,8 +54,6 @@ public class Extension extends Asn1SequenceType {
}
}
- private final boolean critical = false;
-
static Asn1FieldInfo[] fieldInfos = new Asn1FieldInfo[] {
new Asn1FieldInfo(ExtensionField.EXTN_ID, Asn1ObjectIdentifier.class),
new Asn1FieldInfo(ExtensionField.CRITICAL, Asn1Boolean.class),
@@ -64,7 +62,6 @@ public class Extension extends Asn1SequenceType {
public Extension() {
super(fieldInfos);
- setCritical(critical);
}
public Asn1ObjectIdentifier getExtnId() {
http://git-wip-us.apache.org/repos/asf/directory-kerby/blob/624d6534/kerby-pkix/src/test/java/org/apache/kerby/cms/ExtensionTest.java
----------------------------------------------------------------------
diff --git a/kerby-pkix/src/test/java/org/apache/kerby/cms/ExtensionTest.java b/kerby-pkix/src/test/java/org/apache/kerby/cms/ExtensionTest.java
index 7799d1d..7857dcc 100644
--- a/kerby-pkix/src/test/java/org/apache/kerby/cms/ExtensionTest.java
+++ b/kerby-pkix/src/test/java/org/apache/kerby/cms/ExtensionTest.java
@@ -34,6 +34,7 @@ public class ExtensionTest {
Extension extension = new Extension();
extension.setExtnId(new Asn1ObjectIdentifier("1.3.6.1.5.2.3.1"));
extension.setExtnValue("value".getBytes());
+ extension.setCritical(false);
byte[] encodedBytes = extension.encode();
Extension decodedExtension = new Extension();
decodedExtension.decode(encodedBytes);