[GitHub] [solr] dsmiley commented on a change in pull request #621: SOLR-15989: Upgrade to Tika 1.28

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #621:
URL: https://github.com/apache/solr/pull/621#discussion_r803850807



##########
File path: solr/modules/extraction/build.gradle
##########
@@ -26,55 +26,18 @@ dependencies {
   implementation 'org.apache.lucene:lucene-core'
   implementation 'org.slf4j:slf4j-api'
 
-  // We export tika because other modules depend on it (and its submodules)

Review comment:
       I'm glad this was reversed (api -> implementation); maybe the comment was wrong/obsolete




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org