[jira] [Commented] (OPENNLP-1046) Fix OntoNotes4 Parser eval regression

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984382#comment-15984382 ] 

ASF GitHub Bot commented on OPENNLP-1046:
-----------------------------------------

GitHub user kottmann opened a pull request:

    https://github.com/apache/opennlp/pull/185

    OPENNLP-1046: Correctly join tokens to text string

    The text was one space too long which results in a different
    parse tree if the method is used to reproduce an existing
    parse tree as it is done by the parser evaluation tool.
    
    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kottmann/opennlp opennlp-1046

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/185.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #185
    
----
commit f4f1368eeb0d59bc2566d7a353730aaa81c7a961
Author: Jörn Kottmann <jo...@apache.org>
Date:   2017-04-26T08:46:48Z

    OPENNLP-1046: Correctly join tokens to text string
    
    The text was one space too long which results in a different
    parse tree if the method is used to reproduce an existing
    parse tree as it is done by the parser evaluation tool.

----


> Fix OntoNotes4 Parser eval regression
> -------------------------------------
>
>                 Key: OPENNLP-1046
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1046
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Parser
>            Reporter: Joern Kottmann
>            Assignee: Joern Kottmann
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> During a re-factoring of the command line ParserTool a bug was introduced which incorrectly concats tokens, the tokens should be "a b c d" but they are joined as "a b c d " (additional space at the end).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)