[GitHub] [incubator-superset] etr2460 opened a new pull request #7868: [SQL Lab] Fix TableSelector perf for large option sets

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #7868: [SQL Lab] Fix TableSelector perf for large option sets
URL: https://github.com/apache/incubator-superset/pull/7868
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   If you have a large number of tables with a single schema (we have 28k in one of ours), it would take about 10 seconds to load the table selector. This was due to generating the search index, tokenizing, and doing other search-y related things. It turns out that getting rid of the indexing and adding `ignoreAccents={false}` (the same thing as https://github.com/apache/incubator-superset/pull/7791) improves the loading speed (down to under half a second) without hurting the search speed.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - ensure searching for tables in sql lab still works
   - see that it's faster!
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat @michellethomas @khtruong @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org