[GitHub] [qpid-proton] astitcher commented on a change in pull request #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr

[GitBox <gi...@apache.org>]

astitcher commented on a change in pull request #176: NO-JIRA: [c] Fix Coverity warning of buffer overrun in pn_proactor_addr
URL: https://github.com/apache/qpid-proton/pull/176#discussion_r306352167
 
 

 ##########
 File path: c/src/platform/platform.h
 ##########
 @@ -65,7 +65,7 @@ int pn_i_error_from_errno(pn_error_t *error, const char *msg);
  */
 int64_t pn_i_atoll(const char* num);
 
-int pni_snprintf(char *buf, size_t count, const char *fmt, ...);
+PN_EXTERN int pni_snprintf(char *buf, size_t count, const char *fmt, ...);
 
 Review comment:
   Can't do this pni_ prefix means internal only not to be exported.
   If you need to use this in a different library you need to copy the code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org