You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2013/01/08 18:16:13 UTC
[jira] [Comment Edited] (HADOOP-9106) Allow configuration of IPC
connect timeout
[ https://issues.apache.org/jira/browse/HADOOP-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547022#comment-13547022 ]
Suresh Srinivas edited comment on HADOOP-9106 at 1/8/13 5:15 PM:
-----------------------------------------------------------------
Robert, can you please address my previous comment, either with code change or why that change is not necessary.
bq. Please save the connection timeout in a final member varilable in Client instead of getting it from the configuration every time.
Other comments:
# final modifier for static methods seems unnecessary. I know there are arguments for using it. But not sure if it is required in this case.
# Change "final public static" to "public static final"
BTW changing "IPC_CLIENT_CONNECTION_TIMEOUT_KEY" t0 "IPC_CLIENT_CONNECT_TIMEOUT_KEY" is a good change. I should have spotted it.
was (Author: sureshms):
Robert can you please address my previous comment, either with code change or why that change is not necessary.
bq. Please save the connection timeout in a final member varilable in Client instead of getting it from the configuration every time.
Other comments:
# final modifier for static methods seems unnecessary. I know there are arguments for using it. But not sure if it is required in this case.
# Change "final public static" to "public static final"
BTW changing "IPC_CLIENT_CONNECTION_TIMEOUT_KEY" t0 "IPC_CLIENT_CONNECT_TIMEOUT_KEY" is a good change. I should have spotted it.
> Allow configuration of IPC connect timeout
> ------------------------------------------
>
> Key: HADOOP-9106
> URL: https://issues.apache.org/jira/browse/HADOOP-9106
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 3.0.0
> Reporter: Todd Lipcon
> Assignee: Robert Parker
> Attachments: HADOOP-9106v1.patch, HADOOP-9106v2.patch, HADOOP-9106v3.patch
>
>
> Currently the connection timeout in Client.setupConnection() is hard coded to 20seconds. This is unreasonable in some scenarios, such as HA failover, if we want a faster failover time. We should allow this to be configured per-client.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira