[jira] [Commented] (AMQ-8138) STOMP ProtocolConverter error should include client IP information

["Jean-Baptiste Onofré (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392183#comment-17392183 ] 

Jean-Baptiste Onofré commented on AMQ-8138:
-------------------------------------------

That's easy to have the concrete client IP address in the protocol converter as it's based on the stomp command. If the stomp command is empty (it's your case when the SSL handshake is not complete, that's why you have null for both client ID and client IP address in the log message), we don't have details about client. As a little improvement, I'm adding host in the client IP address (not set for now), it would help a little.

> STOMP ProtocolConverter error should include client IP information
> ------------------------------------------------------------------
>
>                 Key: AMQ-8138
>                 URL: https://issues.apache.org/jira/browse/AMQ-8138
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 5.16.1
>            Reporter: Lionel Cons
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 5.16.3
>
>
> On a broker recently upgraded to 5.16.1, I've seen the following warning:
> {code}
> 2021-02-03 16:21:00,745 [ActiveMQ NIO Worker 9] WARN ProtocolConverter - Exception occurred for client null (null) processing: SEND -> org.apache.activemq.transport.stomp.ProtocolException: Not connected.
> {code}
> This looks a lot like AMQ-7444.
> If possible, it would be good to log client IP information for this warning too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)