You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/15 02:58:07 UTC

[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #5179: fix support for test of some pagination

tristaZero commented on a change in pull request #5179: fix support for test of some pagination
URL: https://github.com/apache/incubator-shardingsphere/pull/5179#discussion_r408552154
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/TableFactorSegment.java
 ##########
 @@ -37,6 +38,8 @@
     
     private TableSegment table;
     
+    private SubqueryTableSegment subqueryTableSegment;
 
 Review comment:
   Why do you need `SubqueryTableSegment `? Is the `TableSegment ` not enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services