You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zach Amsden (Code Review)" <ge...@cloudera.org> on 2017/05/15 20:25:00 UTC
[Impala-ASF-CR] IMPALA-5319: Fix error results.
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6890
Change subject: IMPALA-5319: Fix error results.
......................................................................
IMPALA-5319: Fix error results.
Since changing the underlying type in the column, this error no
longer appears.
Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
---
M testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/6890/1
--
To view, visit http://gerrit.cloudera.org:8080/6890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
[Impala-ASF-CR] IMPALA-5319: Fix error results.
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5319: Fix error results.
......................................................................
Patch Set 1:
I miscounted columns and thought the suspect change made column 10 into a timestamp column, in which case the conversion from string would not be happening so the errors would disappear. This was just for a private test run as I am having some weird behavior on my dev box after a recent SDD corruption.
--
To view, visit http://gerrit.cloudera.org:8080/6890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5319: Fix error results.
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5319: Fix error results.
......................................................................
Patch Set 1:
I think the issue is that I changed an extra string type in my recent change in https://gerrit.cloudera.org/#/c/6526/11/testdata/datasets/functional/functional_schema_template.sql
I assigned the jira to myself and will post a fix.
--
To view, visit http://gerrit.cloudera.org:8080/6890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5319: Fix error results.
Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5319: Fix error results.
......................................................................
Patch Set 1: Code-Review-1
--
To view, visit http://gerrit.cloudera.org:8080/6890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5319: Fix error results.
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has abandoned this change.
Change subject: IMPALA-5319: Fix error results.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/6890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
[Impala-ASF-CR] IMPALA-5319: Fix error results.
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change.
Change subject: IMPALA-5319: Fix error results.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6890/1/testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test
File testdata/workloads/functional-query/queries/DataErrorsTest/hdfs-scan-node-errors.test:
PS1, Line 84:
Just for my understanding: why is this error not reported anymore ? Is it because we recently changed the the type of timestamp_col in temp table from string to timestamp ?
--
To view, visit http://gerrit.cloudera.org:8080/6890
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3cf66eb3a8a351cffe85339eaea868ea69ec2be
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes