[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #417: apps/fsutils/ipcfg: Add support for IPv6

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on pull request #417:
URL: https://github.com/apache/incubator-nuttx-apps/pull/417#issuecomment-703208419


   > @xiaoxiang781216 @davids5 There is no impact to the release from this PR (because there is still no user of ipcfg in master) so this could be merged whenever you are comfortable. I have tested pretty thoroughly and I am confident in the state of the changes. I think David has become exasperated since he has closed PR #415 . After this is merged, I will submit a PR to get the IPv4 and IPv6 configuration from the configuration file. I will not implement David's full polling logic from PR #415 , only the logic that gets the IP addresses which I think is non-controversial. It would be nice if you two could resolve your differences and we could make forward progress on that.
   
   Sure, let's go ahead. Actually, all my suggestions are very simple:
   1. Make NETINIT_ESTABLISH_POLL_RATE/NETINIT_LOSS_POLL_RATE available in both interrupt/poll case
   2. Make NETINIT_DHCP_FALLBACK available in both interrupt/poll case
   3. Initialize g_netconf with the default if ipcfg_read return fail to avoid the code duplication
   
   The first two only involve the minor change in Kconfig, the 3rd one just need reorder the initialition code.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org