You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/03 21:42:32 UTC
[GitHub] [arrow] ianmcook opened a new pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
ianmcook opened a new pull request #10234:
URL: https://github.com/apache/arrow/pull/10234
This resolves a problem where Visual Studio 2019 reported syntax errors in `cpp/src/parquet/types.h` after ARROW-11929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#issuecomment-831554820
Revision: 760052d60fa94b56af9d0025ee0cbc48a4475d76
Submitted crossbow builds: [ursacomputing/crossbow @ actions-376](https://github.com/ursacomputing/crossbow/branches/all?query=actions-376)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-376-github-test-build-vcpkg-win)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#discussion_r625758241
##########
File path: cpp/src/parquet/types.h
##########
@@ -17,6 +17,16 @@
#pragma once
+#ifdef _WIN32
+
+// parquet.thrift's OPTIONAL RepetitionType conflicts with a #define from
+// above, so we undefine it
+#ifdef OPTIONAL
+#undef OPTIONAL
+#endif
Review comment:
Done in 1a77246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#issuecomment-831922175
Revision: 1a772469313091122fe810f0c9c07177c47e7412
Submitted crossbow builds: [ursacomputing/crossbow @ actions-378](https://github.com/ursacomputing/crossbow/branches/all?query=actions-378)
|Task|Status|
|----|------|
|test-build-vcpkg-win|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-378-github-test-build-vcpkg-win)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#discussion_r625655299
##########
File path: cpp/src/parquet/types.h
##########
@@ -17,6 +17,16 @@
#pragma once
+#ifdef _WIN32
+
+// parquet.thrift's OPTIONAL RepetitionType conflicts with a #define from
+// above, so we undefine it
+#ifdef OPTIONAL
+#undef OPTIONAL
+#endif
Review comment:
Can you move this after the includes? Also, can you update the comment (there is no "define from above")?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#issuecomment-831554021
https://issues.apache.org/jira/browse/ARROW-12640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#issuecomment-832022390
Thank you @pitrou. I will merge after CI looks green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#issuecomment-831921517
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook closed pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
ianmcook closed pull request #10234:
URL: https://github.com/apache/arrow/pull/10234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on pull request #10234: ARROW-12640: [C++] Fix errors from VS 2019 in cpp/src/parquet/types.h
Posted by GitBox <gi...@apache.org>.
ianmcook commented on pull request #10234:
URL: https://github.com/apache/arrow/pull/10234#issuecomment-831554492
@github-actions crossbow submit test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org