You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Swapnil Bawaskar <sb...@apache.org> on 2016/09/22 07:43:02 UTC

Review Request 52152: GEODE-1921: Redis adaptor Strings region has incorrect attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52152/
-----------------------------------------------------------

Review request for geode.


Repository: geode


Description
-------

- renamed them to redis_strings and redis_hll
- made the strings regions and the hll region PARTITION by default
- these regions are no longer internal regions


Diffs
-----

  geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 45d18864ef8b4ee642b553546e86f483bf7bb1f6 
  geode-core/src/test/java/org/apache/geode/redis/RedisServerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/52152/diff/


Testing
-------


Thanks,

Swapnil Bawaskar


Re: Review Request 52152: GEODE-1921: Redis adaptor Strings region has incorrect attributes

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52152/#review150032
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On Sept. 22, 2016, 12:43 a.m., Swapnil Bawaskar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52152/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2016, 12:43 a.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> - renamed them to redis_strings and redis_hll
> - made the strings regions and the hll region PARTITION by default
> - these regions are no longer internal regions
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/org/apache/geode/redis/GeodeRedisServer.java 45d18864ef8b4ee642b553546e86f483bf7bb1f6 
>   geode-core/src/test/java/org/apache/geode/redis/RedisServerTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52152/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Swapnil Bawaskar
> 
>