You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/12 09:58:17 UTC
[PR] [Subscription] Limit DATE conversion to active tablet rows [iotdb]
Caideyipi opened a new pull request, #18832:
URL: https://github.com/apache/iotdb/pull/18832
ConsensusLogToTabletConverter converted DATE int[] columns across their full backing capacity. InsertTabletNode and RelationalInsertTabletNode can retain unused capacity beyond getRowCount(), where zero-filled DATE slots cause DateTimeParseException on the live consensus subscription path. Pass rowCount through both conversion paths and leave inactive slots null. Added tree/table regression tests with oversized backing arrays. Validation: mvn -o spotless:apply -pl iotdb-core/datanode; direct javac of the changed production/test classes; ConsensusLogToTabletConverterTest OK (17 tests). The full DataNode test-compile remains blocked by pre-existing local SNAPSHOT/generated dependency mismatches unrelated to this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Subscription] Limit DATE conversion to active tablet rows [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18832:
URL: https://github.com/apache/iotdb/pull/18832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Subscription] Limit DATE conversion to active tablet rows [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #18832:
URL: https://github.com/apache/iotdb/pull/18832#issuecomment-6122816501
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/18832?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.91%. Comparing base ([`932c1da`](https://app.codecov.io/gh/apache/iotdb/commit/932c1da25f7e472e84d2a997b376e10b02270c26?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5cb38ae`](https://app.codecov.io/gh/apache/iotdb/commit/5cb38ae089572da7a60c058aa4ad494419f653ef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/18832?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...roker/consensus/ConsensusLogToTabletConverter.java](https://app.codecov.io/gh/apache/iotdb/pull/18832?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fsubscription%2Fbroker%2Fconsensus%2FConsensusLogToTabletConverter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvc3Vic2NyaXB0aW9uL2Jyb2tlci9jb25zZW5zdXMvQ29uc2Vuc3VzTG9nVG9UYWJsZXRDb252ZXJ0ZXIuamF2YQ==) | 50.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/18832?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18832 +/- ##
=========================================
Coverage 45.91% 45.91%
Complexity 712 712
=========================================
Files 5502 5502
Lines 398775 398775
Branches 51967 51967
=========================================
+ Hits 183080 183099 +19
+ Misses 215695 215676 -19
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/18832?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org