You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/21 13:39:50 UTC
[GitHub] [superset] villebro opened a new pull request #12660: [WIP] fix(multiline): return chart data on data request
villebro opened a new pull request #12660:
URL: https://github.com/apache/superset/pull/12660
### SUMMARY
Move the multiline logic from frontend to backend to avoid multiple requests. Requires https://github.com/apache-superset/superset-ui/pull/899 to be merged and deployed and bumped in this PR.
### SCREENSHOT
### TEST PLAN
Local testing
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: closes #12268
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-765348570
@adam-stasiak that's peculiar, I wonder if your frontend assets are properly rebuilt? With the new version of the NVD3 package `axis1` shouldn't be present in the codebase any longer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `0.93%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.62% -0.94%
==========================================
Files 1018 486 -532
Lines 49787 30012 -19775
Branches 4971 0 -4971
==========================================
- Hits 32141 19094 -13047
+ Misses 17468 10918 -6550
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.62% <0.00%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset-frontend/src/messageToasts/types.ts](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdHlwZXMudHM=) | | |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | | |
| [...oard/components/gridComponents/new/NewMarkdown.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdNYXJrZG93bi5qc3g=) | | |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | | |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: [WIP] fix(multiline): return chart data on data request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (853c71b) into [master](https://codecov.io/gh/apache/superset/commit/734fb75219c96abd2a8323a0650f2e93caa054e8?el=desc) (734fb75) will **decrease** coverage by `3.40%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 66.85% 63.44% -3.41%
==========================================
Files 1018 486 -532
Lines 49776 30006 -19770
Branches 4869 0 -4869
==========================================
- Hits 33278 19038 -14240
+ Misses 16375 10968 -5407
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.44% <0.00%> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.21% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...ard/components/filterscope/FilterScopeSelector.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlU2VsZWN0b3IuanN4) | | |
| [...t-frontend/src/dashboard/components/IconButton.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ljb25CdXR0b24uanN4) | | |
| [...ontend/src/dashboard/util/getChartIdsFromLayout.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0SWRzRnJvbUxheW91dC5qcw==) | | |
| [...-frontend/src/explore/components/RowCountLabel.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsLmpzeA==) | | |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [734fb75...853c71b](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-765340215
@villebro Should I do extra steps to make this working? When I open multiline chart I got this:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #12660:
URL: https://github.com/apache/superset/pull/12660#discussion_r562540388
##########
File path: superset/viz.py
##########
@@ -1405,21 +1405,55 @@ def query_obj(self) -> QueryObjectDict:
return {}
def get_data(self, df: pd.DataFrame) -> VizData:
- fd = self.form_data
- # Late imports to avoid circular import issues
- from superset import db
- from superset.models.slice import Slice
-
- slice_ids1 = fd.get("line_charts")
- slices1 = db.session.query(Slice).filter(Slice.id.in_(slice_ids1)).all()
- slice_ids2 = fd.get("line_charts_2")
- slices2 = db.session.query(Slice).filter(Slice.id.in_(slice_ids2)).all()
- return {
- "slices": {
- "axis1": [slc.data for slc in slices1],
- "axis2": [slc.data for slc in slices2],
- }
- }
+ multiline_fd = self.form_data
+ # Late import to avoid circular import issues
+ from superset.charts.dao import ChartDAO
+
+ axis1_charts = ChartDAO.find_by_ids(multiline_fd.get("line_charts", []))
+ axis2_charts = ChartDAO.find_by_ids(multiline_fd.get("line_charts_2", []))
Review comment:
I did a slight variation of this to that doesn't fail if there are duplicates (shouldn't be the case, but you never know).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (3cd726c) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `1.17%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.38% -1.18%
==========================================
Files 1018 486 -532
Lines 49787 30007 -19780
Branches 4971 0 -4971
==========================================
- Hits 32141 19020 -13121
+ Misses 17468 10987 -6481
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.38% <0.00%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.23% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...3cd726c](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-765482259
I rerun npm install and docker and now without an issue:) 🟢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #12660:
URL: https://github.com/apache/superset/pull/12660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: [WIP] fix(multiline): return chart data on data request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (853c71b) into [master](https://codecov.io/gh/apache/superset/commit/734fb75219c96abd2a8323a0650f2e93caa054e8?el=desc) (734fb75) will **decrease** coverage by `3.40%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 66.85% 63.44% -3.41%
==========================================
Files 1018 486 -532
Lines 49776 30006 -19770
Branches 4869 0 -4869
==========================================
- Hits 33278 19038 -14240
+ Misses 16375 10968 -5407
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.44% <0.00%> (-0.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.21% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci5qcw==) | | |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | | |
| [...et-frontend/src/components/Label/Label.stories.tsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvTGFiZWwuc3Rvcmllcy50c3g=) | | |
| ... and [528 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [734fb75...853c71b](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12660: [WIP] fix(multiline): return chart data on data request
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (853c71b) into [master](https://codecov.io/gh/apache/superset/commit/734fb75219c96abd2a8323a0650f2e93caa054e8?el=desc) (734fb75) will **decrease** coverage by `3.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 66.85% 63.36% -3.49%
==========================================
Files 1018 486 -532
Lines 49776 29991 -19785
Branches 4869 0 -4869
==========================================
- Hits 33278 19005 -14273
+ Misses 16375 10986 -5389
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.36% <0.00%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.21% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [734fb75...853c71b](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `1.29%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.26% -1.30%
==========================================
Files 1018 486 -532
Lines 49787 29997 -19790
Branches 4971 0 -4971
==========================================
- Hits 32141 18978 -13163
+ Misses 17468 11019 -6449
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.26% <0.00%> (-0.87%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `93.40% <0.00%> (-6.05%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [553 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12660:
URL: https://github.com/apache/superset/pull/12660#discussion_r562471718
##########
File path: superset/viz.py
##########
@@ -1405,21 +1405,55 @@ def query_obj(self) -> QueryObjectDict:
return {}
def get_data(self, df: pd.DataFrame) -> VizData:
- fd = self.form_data
- # Late imports to avoid circular import issues
- from superset import db
- from superset.models.slice import Slice
-
- slice_ids1 = fd.get("line_charts")
- slices1 = db.session.query(Slice).filter(Slice.id.in_(slice_ids1)).all()
- slice_ids2 = fd.get("line_charts_2")
- slices2 = db.session.query(Slice).filter(Slice.id.in_(slice_ids2)).all()
- return {
- "slices": {
- "axis1": [slc.data for slc in slices1],
- "axis2": [slc.data for slc in slices2],
- }
- }
+ multiline_fd = self.form_data
+ # Late import to avoid circular import issues
+ from superset.charts.dao import ChartDAO
+
+ axis1_charts = ChartDAO.find_by_ids(multiline_fd.get("line_charts", []))
+ axis2_charts = ChartDAO.find_by_ids(multiline_fd.get("line_charts_2", []))
Review comment:
It might be possible to combine these two queries into one:
```python
axis1_chart_ids = multiline_fd.get("line_charts", [])
axis2_chart_ids = multiline_fd.get("line_charts_2", [])
all_charts = ChartDAO.find_by_ids(axis1_chart_ids + axis2_chart_ids)
axis1_charts = all_charts[:len(axis1_chart_ids)]
axis2_charts = all_charts[len(axis1_chart_ids):]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: [WIP] fix(multiline): return chart data on data request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (853c71b) into [master](https://codecov.io/gh/apache/superset/commit/734fb75219c96abd2a8323a0650f2e93caa054e8?el=desc) (734fb75) will **decrease** coverage by `3.43%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 66.85% 63.41% -3.44%
==========================================
Files 1018 486 -532
Lines 49776 29991 -19785
Branches 4869 0 -4869
==========================================
- Hits 33278 19019 -14259
+ Misses 16375 10972 -5403
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.41% <0.00%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.21% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.68% <0.00%> (-0.47%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [539 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [734fb75...853c71b](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **increase** coverage by `1.98%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
+ Coverage 64.55% 66.53% +1.98%
==========================================
Files 1018 1018
Lines 49787 49820 +33
Branches 4971 4877 -94
==========================================
+ Hits 32141 33150 +1009
+ Misses 17468 16543 -925
+ Partials 178 127 -51
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.58% <ø> (+13.38%)` | :arrow_up: |
| javascript | `60.94% <ø> (ø)` | |
| python | `63.62% <0.00%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-7.60%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.58% <0.00%> (-5.07%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.59% <0.00%> (-3.61%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [132 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (3cd726c) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `1.16%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.39% -1.17%
==========================================
Files 1018 486 -532
Lines 49787 29992 -19795
Branches 4971 0 -4971
==========================================
- Hits 32141 19013 -13128
+ Misses 17468 10979 -6489
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.39% <0.00%> (-0.74%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.23% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.59% <0.00%> (-6.38%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.25% <0.00%> (-5.85%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [551 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...3cd726c](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `1.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 62.55% -2.00%
==========================================
Files 1018 1018
Lines 49787 49801 +14
Branches 4971 4877 -94
==========================================
- Hits 32141 31155 -986
- Misses 17468 18448 +980
- Partials 178 198 +20
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.94% <ø> (ø)` | |
| python | `63.62% <0.00%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-93.34%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.ts](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy50cw==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| ... and [95 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **increase** coverage by `2.06%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
+ Coverage 64.55% 66.62% +2.06%
==========================================
Files 1018 1018
Lines 49787 49820 +33
Branches 4971 4877 -94
==========================================
+ Hits 32141 33193 +1052
+ Misses 17468 16504 -964
+ Partials 178 123 -55
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.96% <ø> (+13.75%)` | :arrow_up: |
| javascript | `60.94% <ø> (ø)` | |
| python | `63.62% <0.00%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.04% <0.00%> (-0.82%)` | :arrow_down: |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `69.31% <0.00%> (+0.16%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `62.42% <0.00%> (+0.21%)` | :arrow_up: |
| [.../explore/components/controls/DateFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC5qc3g=) | `56.32% <0.00%> (+0.57%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `81.88% <0.00%> (+0.78%)` | :arrow_up: |
| ... and [129 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12660: [WIP] fix(multiline): return chart data on data request
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (853c71b) into [master](https://codecov.io/gh/apache/superset/commit/734fb75219c96abd2a8323a0650f2e93caa054e8?el=desc) (734fb75) will **decrease** coverage by `3.48%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 66.85% 63.36% -3.49%
==========================================
Files 1018 486 -532
Lines 49776 29991 -19785
Branches 4869 0 -4869
==========================================
- Hits 33278 19005 -14273
+ Misses 16375 10986 -5389
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.36% <0.00%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.21% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.56% <0.00%> (-10.83%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `93.42% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.69% <0.00%> (-1.66%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [734fb75...853c71b](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (3cd726c) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `0.77%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.78% -0.78%
==========================================
Files 1018 486 -532
Lines 49787 30007 -19780
Branches 4971 0 -4971
==========================================
- Hits 32141 19140 -13001
+ Misses 17468 10867 -6601
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.78% <0.00%> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.23% <0.00%> (-0.79%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.86% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.82% <0.00%> (-2.48%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| ... and [540 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...3cd726c](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: [WIP] fix(multiline): return chart data on data request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `0.97%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.58% -0.98%
==========================================
Files 1018 486 -532
Lines 49787 30012 -19775
Branches 4971 0 -4971
==========================================
- Hits 32141 19083 -13058
+ Misses 17468 10929 -6539
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <0.00%> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.85% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [...t-frontend/src/components/DynamicPlugins/index.tsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHluYW1pY1BsdWdpbnMvaW5kZXgudHN4) | | |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12660: fix(multiline): return all chart data on initial request
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12660:
URL: https://github.com/apache/superset/pull/12660#issuecomment-764732807
# [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=h1) Report
> Merging [#12660](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=desc) (e7bffc1) into [master](https://codecov.io/gh/apache/superset/commit/5504762458e127063e36f5aa149bbdf3f6fc8f80?el=desc) (5504762) will **decrease** coverage by `0.97%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12660 +/- ##
==========================================
- Coverage 64.55% 63.58% -0.98%
==========================================
Files 1018 486 -532
Lines 49787 30012 -19775
Branches 4971 0 -4971
==========================================
- Hits 32141 19083 -13058
+ Misses 17468 10929 -6539
+ Partials 178 0 -178
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <0.00%> (-0.55%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.06% <0.00%> (-0.97%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (-1.64%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.85% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.45% <0.00%> (-0.14%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | | |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/12660/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=footer). Last update [5504762...e7bffc1](https://codecov.io/gh/apache/superset/pull/12660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org