[GitHub] [couchdb] chewbranca commented on a change in pull request #2458: Fix fabric worker failures for partition requests

[GitBox <gi...@apache.org>]

chewbranca commented on a change in pull request #2458: Fix fabric worker failures for partition requests
URL: https://github.com/apache/couchdb/pull/2458#discussion_r367169485
 
 

 ##########
 File path: src/dreyfus/src/dreyfus_util.erl
 ##########
 @@ -59,6 +59,15 @@ use_ushards(#index_query_args{stable=true}) ->
 use_ushards(#index_query_args{}) ->
     false.
 
+
+get_ring_opts(#index_query_args{partition = nil}, _Shards) ->
+    [];
+get_ring_opts(#index_query_args{}, Shards) ->
+    Shards1 = lists:map(fun(#shard{} = S) ->
+        S#shard{ref = undefined}
 
 Review comment:
   What's the purpose of clearing the refs here for _only_ the dreyfus shards? I haven't looked exhaustively, but I didn't see a reason as to why you would not want to clear out the ref in the list of shards for Dreyfus, but below in `fabric_db_partition_info.erl` you're basically doing `[{any, mem3:shards(DbName, couch_partition:shard_key(Partition))}]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services