[GitHub] [lucene-solr] jpountz commented on a change in pull request #2051: LUCENE-9594 Add linear function for FeatureField

[GitBox <gi...@apache.org>]

jpountz commented on a change in pull request #2051:
URL: https://github.com/apache/lucene-solr/pull/2051#discussion_r520408605



##########
File path: lucene/core/src/java/org/apache/lucene/document/FeatureField.java
##########
@@ -66,8 +66,11 @@
  * 2<sup>-8</sup> = 0.00390625.
  * <p>
  * Given a scoring factor {@code S > 0} and its weight {@code w > 0}, there
- * are three ways that S can be turned into a score:
+ * are four ways that S can be turned into a score:
  * <ul>
+ *   <li>{@link #newLinearQuery w * S}. This is the simplest function
+ *       where no transformation is applied on the feature value, and
+ *       the feature value itself multiplied by weight defines the score.

Review comment:
       "the simplest" might suggest that this would be a good one to start with, when in fact I think this is the most expert function in my opinion given that it expects the feature to already be encoded in the index in a way that makes sense for scoring. Maybe javadocs should better convey that this is expert functionality?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org