You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "TezQA (Jira)" <ji...@apache.org> on 2020/01/15 11:41:00 UTC

[jira] [Commented] (TEZ-4101) Eliminate some guava dependencies by Java8+ features - Preconditions

    [ https://issues.apache.org/jira/browse/TEZ-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015870#comment-17015870 ] 

TezQA commented on TEZ-4101:
----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  9m 52s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  2s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m  0s{color} | {color:green} The patch appears to include 17 new or modified test files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  3m 54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  4m 26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  4m  7s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  0m 36s{color} | {color:blue} Used deprecated FindBugs config; considering switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  7m 46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 33s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 19s{color} | {color:orange} tez-api: The patch generated 2 new + 316 unchanged - 0 fixed = 318 total (was 316) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 10s{color} | {color:orange} tez-common: The patch generated 5 new + 37 unchanged - 0 fixed = 42 total (was 37) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 15s{color} | {color:orange} tez-mapreduce: The patch generated 1 new + 178 unchanged - 0 fixed = 179 total (was 178) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  0m 51s{color} | {color:orange} tez-dag: The patch generated 2 new + 1524 unchanged - 0 fixed = 1526 total (was 1524) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  3m 30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 10m 40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 53s{color} | {color:green} tez-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 25s{color} | {color:green} tez-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 41s{color} | {color:green} tez-runtime-internals in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  4m 59s{color} | {color:green} tez-runtime-library in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 14s{color} | {color:green} tez-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 10s{color} | {color:green} tez-examples in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  6m  1s{color} | {color:red} tez-dag in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 51m 31s{color} | {color:red} tez-tests in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  2m 54s{color} | {color:red} tez-ext-service-tests in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 30s{color} | {color:green} tez-history-parser in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 49s{color} | {color:green} job-analyzer in the patch passed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red}  2m  0s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m 43s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.app.rm.TestTaskSchedulerManager |
|   | tez.dag.app.TestSpeculation |
|   | tez.tests.TestExternalTezServicesErrors |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4101 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12990963/TEZ-4101.01.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 33ca0f5a0a1e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 271351b |
| Default Java | 1.8.0_232 |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/diff-checkstyle-tez-api.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/diff-checkstyle-tez-common.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/diff-checkstyle-tez-mapreduce.txt |
| checkstyle | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/diff-checkstyle-tez-dag.txt |
| whitespace | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/whitespace-eol.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/patch-unit-tez-dag.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/patch-unit-tez-tests.txt |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/patch-unit-tez-ext-service-tests.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/246/testReport/ |
| asflicense | https://builds.apache.org/job/PreCommit-TEZ-Build/246/artifact/out/patch-asflicense-problems.txt |
| Max. process+thread count | 1158 (vs. ulimit of 5500) |
| modules | C: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ext-service-tests tez-plugins/tez-history-parser tez-tools/analyzers/job-analyzer U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/246/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |


This message was automatically generated.



> Eliminate some guava dependencies by Java8+ features - Preconditions
> --------------------------------------------------------------------
>
>                 Key: TEZ-4101
>                 URL: https://issues.apache.org/jira/browse/TEZ-4101
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-4101.01.patch
>
>
> 1. Preconditions.checkNotNull -> Objects.requireNonNull
> 2. wrap others into a tez common class



--
This message was sent by Atlassian Jira
(v8.3.4#803005)