You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/01 14:41:05 UTC

[GitHub] [spark] MaxGekk commented on pull request #38712: [WIP][SPARK-41271][SQL] Parameterized SQL queries

MaxGekk commented on PR #38712:
URL: https://github.com/apache/spark/pull/38712#issuecomment-1333867601

   > Can we provide more motivation for why we are picking the syntax used in this implementation?
   
   @xkrogen The `@` marker has been chosen to make migrating from BigQuery to Spark SQL easier.
   
   > [SQL-92 defined ANSI Dynamic SQL](https://docs.oracle.com/cd/A81042_01/DOC/appdev.816/a76942/pc_14ady.htm) which uses colons (:id).
   
   Actually, this is just Oracle's proprietary implementation.
   
   > I feel we should at least follow the ANSI standard and use colons rather than at-signs.
   
   I agree that we should follow standards whenever it is possible but there are no standards for this feature so far.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org