You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/19 14:13:48 UTC
[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #9707: ARROW-11984: [C++] Implement SHA128 and SHA256 functions in Gandiva module - WIP
anthonylouisbsb commented on a change in pull request #9707:
URL: https://github.com/apache/arrow/pull/9707#discussion_r597711030
##########
File path: cpp/src/gandiva/gdv_function_stubs.cc
##########
@@ -122,6 +123,133 @@ int32_t gdv_fn_populate_varlen_vector(int64_t context_ptr, int8_t* data_ptr,
return 0;
}
+#define SHA128_HASH_FUNCTION(TYPE) \
+ GANDIVA_EXPORT \
+ const char *gdv_fn_sha128_##TYPE(int64_t context, gdv_##TYPE value, \
+ bool validity, int32_t *out_length) { \
+ if (!validity) { \
+ *out_length = 0; \
+ return ""; \
Review comment:
Added the implementation for the SHA hashes in null values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org