You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:04:30 UTC
[GitHub] [maven-site] pat-lego opened a new pull request #246: Adding .mavenrc documentation
pat-lego opened a new pull request #246:
URL: https://github.com/apache/maven-site/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r668139207
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in USER_HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was dynamically set by the .mavenrc file.
Review comment:
This is not correct. Read the files:
https://github.com/apache/maven/blob/1052ec5d871963cd662e7b6a4608cab30a63d79e/apache-maven/src/assembly/shared/validate.cmd#L40-L41
https://github.com/apache/maven/blob/1052ec5d871963cd662e7b6a4608cab30a63d79e/apache-maven/src/assembly/shared/validate#L36-L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] pat-lego commented on a change in pull request #246: Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
pat-lego commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r673484045
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in USER_HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was dynamically set by the .mavenrc file.
Review comment:
I have updated the path for the .mavenrc apologies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] pat-lego commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
pat-lego commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r717839471
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
@michael-o I have updated the document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r717781493
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
"this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project"
-->
"this file defines environment variables and system properties used when Maven builds the project"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r718236995
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
Please see: https://github.com/apache/maven/blob/b6186e2c7714158b5a2709f4af9d40b194c53f55/apache-maven/src/bin/mvn.cmd#L37-L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r673489743
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
There is also `mavenrc` from two locations: https://github.com/apache/maven/commit/2321e03a9415c8edd59f67e22174bf60ec457e66
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
* Use monospace formatting for paths
* Windows, not Windows
* environment, not ENV
* Which other properties? I see only environment variables or system relevant configuration
* reading => building
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r718236995
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
Please see: https://github.com/apache/maven/blob/b6186e2c7714158b5a2709f4af9d40b194c53f55/apache-maven/src/bin/mvn.cmd#L37-L39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] pat-lego commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
pat-lego commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r717839471
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
@michael-o I have updated the document
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
@michael-o did you want to update something to use `%USERPROFILE%`? Not sure what is being requested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] elharo commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r717781493
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
"this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project"
-->
"this file defines environment variables and system properties used when Maven builds the project"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r673488916
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
* Use monospace formatting for paths
* Windows, not windows
* environment, not ENV
* Which other properties? I see only environment variables or system relevant configuration
* reading => building
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] pat-lego commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
pat-lego commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r717842723
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
@michael-o did you want to update something to use `%USERPROFILE%`? Not sure what is being requested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r673488916
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in $HOME/.mavenrc (or %HOME%\mavenrc_pre.bat on windows) this file allows you to define scripts which can set ENV variables and other properties prior to Maven reading the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
* Use monospace formatting for paths
* Windows, not windows
* environment, not ENV
* Which other properties? I see only environment variables or system relevant configuration
* reading => building
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
`%USERPROFILE%`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #246: [MNGSITE-246] Adding .mavenrc documentation
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #246:
URL: https://github.com/apache/maven-site/pull/246#discussion_r717840438
##########
File path: content/markdown/configure.md
##########
@@ -80,6 +80,12 @@ Starting with Maven 3.3.1+ you can define JVM configuration via `${maven.project
You don't need to use these options in `MAVEN_OPTS` or switch between different configurations.
+
+### `.mavenrc` file:
+
+Located in `$HOME/.mavenrc` (or `%HOME%\mavenrc_pre.bat` on Windows) this file allows you to define scripts which can set environment variables or system properties prior to Maven building the project. This allows users to define variables in either the settings.xml or pom.xml and have them read the property that was set by the .mavenrc file.
Review comment:
`%USERPROFILE%`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org