[GitHub] [datasketches-java] AlexanderSaydakov commented on a diff in pull request #448: Revert items changes prepare4.1.0

["AlexanderSaydakov (via GitHub)" <gi...@apache.org>]

AlexanderSaydakov commented on code in PR #448:
URL: https://github.com/apache/datasketches-java/pull/448#discussion_r1213791700


##########
src/main/java/org/apache/datasketches/kll/KllHelper.java:
##########
@@ -237,10 +244,11 @@ static void compressWhileUpdatingSketch(final KllSketch sketch) {
       }
       for (int lvl = 0; lvl < level; lvl++) {
         newIndex = myLevelsArr[lvl] + halfAdjPop; //adjust boundary
-        sketch.setLevelsArrayAt(lvl, newIndex);
+        fltSk.setLevelsArrayAt(lvl, newIndex);
       }
-      sketch.setFloatItemsArray(myFloatItemsArr);
+      fltSk.setFloatItemsArray(myFloatItemsArr);
     }
+    //TODO add items

Review Comment:
   what does this mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org