[jira] [Commented] (KAFKA-8955) Add an AbstractResponse#errorCounts method that takes a stream or iterable

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074711#comment-17074711 ] 

ASF GitHub Bot commented on KAFKA-8955:
---------------------------------------

tombentley commented on pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy
URL: https://github.com/apache/kafka/pull/8417
 
 
   * Add AbstractResponse#errorCounts(Stream) to avoid having to call
     AbstractResponse#errorCounts(Collection) with a computed collection.
   
   * Use updateErrorMap() consistently.
   
   * Replace a couple of forEach() with for statements for consistency.
   
   * Use singleton errorMap() consistently.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add an AbstractResponse#errorCounts method that takes a stream or iterable
> --------------------------------------------------------------------------
>
>                 Key: KAFKA-8955
>                 URL: https://issues.apache.org/jira/browse/KAFKA-8955
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Colin McCabe
>            Assignee: Tom Bentley
>            Priority: Minor
>
> We should have an AbstractResponse#errorCounts method that takes a stream or iterable.  This would allow us to avoid copying data in many cases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)